Closed
Bug 43417
Opened 24 years ago
Closed 24 years ago
Dragging a tree item doesn't first select the cell
Categories
(Core :: XUL, defect, P3)
Core
XUL
Tracking
()
VERIFIED
FIXED
M18
People
(Reporter: mikepinkerton, Assigned: bryner)
Details
(Whiteboard: [nsbeta2+][dogfood-])
Attachments
(1 file)
7.96 KB,
patch
|
Details | Diff | Splinter Review |
If you select an message in the mail thread pane, then click and drag another to a folder, you'll end up moving the first item because the mail trees use selection and the item you dragged is never selected. this can be very very confusing as you can end up moving something different than what you thought (on macos, you even _see_ the object you're dragging but you are operating on something else).
Comment 2•24 years ago
|
||
Putting on [nsbeta2+][dogfood-] radar. Does not need a fix ASAP for daily work, but we should fix this for beta2.
Whiteboard: [nsbeta2+][dogfood-]
Assignee | ||
Comment 3•24 years ago
|
||
Hm, it looks like this can be fixed by changing the selectElement handler in treeBindings.xml from a click handler to a mousedown handler. Will that work, or is there more to it?
Comment 4•24 years ago
|
||
There are subtleties. Sometimes selection happens on a mousedown, and sometimes it happens on a mouseup. We should talk about it, and then produce a patch.
Reporter | ||
Updated•24 years ago
|
Target Milestone: --- → M18
Assignee | ||
Comment 5•24 years ago
|
||
Reassigning to myself. Keeping hyatt on CC in case he wants to add input.
Assignee: hyatt → bryner
Assignee | ||
Updated•24 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 6•24 years ago
|
||
Assignee | ||
Comment 7•24 years ago
|
||
Ok, the patch I just attached should take care of a lot of problems involving multiple selection, including this one.
Assignee | ||
Comment 8•24 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Comment 9•24 years ago
|
||
verified fixed. The cell is selected at the beginning of the drag (onmousedown). mac/win32/linux 20000712nn builds -- tested in mail, bookmarks. [Although, on the drop end of this action, there is a crash -- bug 45361]
Status: RESOLVED → VERIFIED
Comment 10•24 years ago
|
||
Adding keyword to bugs which already show a nsbeta2 triage value in the status whiteboard so the queries don't get screwed up.
Keywords: nsbeta2
Component: XP Toolkit/Widgets: Trees → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in
before you can comment on or make changes to this bug.
Description
•