Dragging a tree item doesn't first select the cell

VERIFIED FIXED in M18

Status

()

P3
normal
VERIFIED FIXED
18 years ago
10 years ago

People

(Reporter: mikepinkerton, Assigned: bryner)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [nsbeta2+][dogfood-])

Attachments

(1 attachment)

(Reporter)

Description

18 years ago
If you select an message in the mail thread pane, then click and drag another to 
a folder, you'll end up moving the first item because the mail trees use 
selection and the item you dragged is never selected.

this can be very very confusing as you can end up moving something different than 
what you thought (on macos, you even _see_ the object you're dragging but you are 
operating on something else).
(Reporter)

Comment 1

18 years ago
sorry hyatt, this is dogfood.
Keywords: dogfood

Comment 2

18 years ago
Putting on [nsbeta2+][dogfood-] radar.  Does not need a fix ASAP for daily work, 
but we should fix this for beta2. 
Whiteboard: [nsbeta2+][dogfood-]
(Assignee)

Comment 3

18 years ago
Hm, it looks like this can be fixed by changing the selectElement handler in
treeBindings.xml from a click handler to a mousedown handler.  Will that work,
or is there more to it?

Comment 4

18 years ago
There are subtleties.  Sometimes selection happens on a mousedown, and sometimes 
it happens on a mouseup.  We should talk about it, and then produce a patch.
(Reporter)

Updated

18 years ago
Target Milestone: --- → M18
(Assignee)

Comment 5

18 years ago
Reassigning to myself.  Keeping hyatt on CC in case he wants to add input.
Assignee: hyatt → bryner
(Assignee)

Updated

18 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 7

18 years ago
Ok, the patch I just attached should take care of a lot of problems involving
multiple selection, including this one.
(Assignee)

Comment 8

18 years ago
Fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 9

18 years ago
verified fixed. The cell is selected at the beginning of the drag 
(onmousedown). mac/win32/linux 20000712nn builds -- tested in mail, bookmarks. 

[Although, on the drop end of this action, there is a crash -- bug 45361]
Status: RESOLVED → VERIFIED
Adding keyword to bugs which already show a nsbeta2 triage value in the status 
whiteboard so the queries don't get screwed up.
Keywords: nsbeta2

Updated

10 years ago
Component: XP Toolkit/Widgets: Trees → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.