43417 - Dragging a tree item doesn't first select the cell

Status: VERIFIED FIXED

(Core :: XUL, defect, P3)

Description

[Mike Pinkerton (not reading bugmail)]

If you select an message in the mail thread pane, then click and drag another to 
a folder, you'll end up moving the first item because the mail trees use 
selection and the item you dragged is never selected.

this can be very very confusing as you can end up moving something different than 
what you thought (on macos, you even _see_ the object you're dragging but you are 
operating on something else).

Comment 1

[Mike Pinkerton (not reading bugmail)]

sorry hyatt, this is dogfood.

Comment 2

[Jay Patel [:jay]]

Putting on [nsbeta2+][dogfood-] radar.  Does not need a fix ASAP for daily work, 
but we should fix this for beta2. 

Comment 3

[Brian Ryner (not reading)]

Hm, it looks like this can be fixed by changing the selectElement handler in
treeBindings.xml from a click handler to a mousedown handler.  Will that work,
or is there more to it?

Comment 4

[David Hyatt]

There are subtleties.  Sometimes selection happens on a mousedown, and sometimes 
it happens on a mouseup.  We should talk about it, and then produce a patch.

Comment 5

[Brian Ryner (not reading)]

Reassigning to myself.  Keeping hyatt on CC in case he wants to add input.

Comment 6

[Brian Ryner (not reading)]

Attachment: patch

Comment 7

[Brian Ryner (not reading)]

Ok, the patch I just attached should take care of a lot of problems involving
multiple selection, including this one.

Comment 8

[Brian Ryner (not reading)]

Fix checked in.

Comment 9

[John Morrison]

verified fixed. The cell is selected at the beginning of the drag 
(onmousedown). mac/win32/linux 20000712nn builds -- tested in mail, bookmarks. 

[Although, on the drop end of this action, there is a crash -- bug 45361]

Comment 10

[Daniel Veditz [:dveditz]]

Adding keyword to bugs which already show a nsbeta2 triage value in the status 
whiteboard so the queries don't get screwed up.