43424 - Change nsIDOMXULDocument --> nsIDOMDocument

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Doug Turner (:dougt)]

Currently editor QI's for a nsIDOMXULDocument on the domWindow's DocShell passed 
via nsIEditorShell::SetWebShellWindow.  This is done and passed to the 
StateMaintainer.  However, nowhere in either the StateMaintainer nor the shell 
is any attribute of the nsIDOMXULDocument used.  

I would like instead QI for the nsIDOMDocument which is one layer directory 
below the nsIDOMXULDocument.  Doing so would allow me to embed simple text 
widgets without requiring a WebShellWindow that is XUL.  Clearly, we need to 
break this requirement in the longer short term, but that is another bug and 
issue.  

I will attach a diff of my changes.  Once applied, we can embed editible plain 
text widgets directly into a native app with about 11 lines of code.

This is a high priority for the embedding team.

Comment 1

[Doug Turner (:dougt)]

Attachment: proposed patch

Comment 2

[Akkana Peck]

I'll take a look at this.

Comment 3

[Judson Valeski]

nom nsbeta2 so our embedding customers don't have to pull xul in to do editor 
fun.

Comment 4

[Phil Peterson]

Ok, talked to Jud on the phone and we agreed to unblock this work, and then have
a more general discussion of embedding priorities and risks next week. Marking
nsbeta2+.

Comment 5

[Akkana Peck]

The changes look fine.  Thanks for doing this -- let's check them in!

Comment 6

[Doug Turner (:dougt)]

checked in. thanks all

Comment 7

[sujay]

I need help verifying this one....Akkana? thanks!

Comment 8

[Akkana Peck]

I think dougt and I are both happy with the changes -- I'll mark it verified (if
anyone doesn't agree, please reopen).