Change nsIDOMXULDocument --> nsIDOMDocument

VERIFIED FIXED in M17

Status

()

P3
normal
VERIFIED FIXED
18 years ago
17 years ago

People

(Reporter: dougt, Assigned: akkzilla)

Tracking

Trunk
x86
Windows NT
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [nsbeta2+])

Attachments

(1 attachment)

(Reporter)

Description

18 years ago
Currently editor QI's for a nsIDOMXULDocument on the domWindow's DocShell passed 
via nsIEditorShell::SetWebShellWindow.  This is done and passed to the 
StateMaintainer.  However, nowhere in either the StateMaintainer nor the shell 
is any attribute of the nsIDOMXULDocument used.  

I would like instead QI for the nsIDOMDocument which is one layer directory 
below the nsIDOMXULDocument.  Doing so would allow me to embed simple text 
widgets without requiring a WebShellWindow that is XUL.  Clearly, we need to 
break this requirement in the longer short term, but that is another bug and 
issue.  

I will attach a diff of my changes.  Once applied, we can embed editible plain 
text widgets directly into a native app with about 11 lines of code.

This is a high priority for the embedding team.
(Reporter)

Comment 1

18 years ago
Created attachment 10505 [details] [diff] [review]
proposed patch
(Assignee)

Comment 2

18 years ago
I'll take a look at this.
Assignee: beppe → akkana
Target Milestone: --- → M17

Comment 3

18 years ago
nom nsbeta2 so our embedding customers don't have to pull xul in to do editor 
fun.
Keywords: nsbeta2

Comment 4

18 years ago
Ok, talked to Jud on the phone and we agreed to unblock this work, and then have
a more general discussion of embedding priorities and risks next week. Marking
nsbeta2+.
Whiteboard: [nsbeta2+]
(Assignee)

Comment 5

18 years ago
The changes look fine.  Thanks for doing this -- let's check them in!
Status: NEW → ASSIGNED
(Reporter)

Comment 6

18 years ago
checked in. thanks all
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 7

18 years ago
I need help verifying this one....Akkana? thanks!
(Assignee)

Comment 8

18 years ago
I think dougt and I are both happy with the changes -- I'll mark it verified (if
anyone doesn't agree, please reopen).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.