Closed Bug 434244 Opened 14 years ago Closed 14 years ago

Remove mozStorageStatement::Recreate

Categories

(Toolkit :: Storage, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: sdwilsh, Assigned: sdwilsh)

Details

Attachments

(1 file)

This is no longer needed since we use sqlite3_prepare_v2.  The only place we call it is when we check sqlite3_expired, which is now obsolete (when using sqlite3_prepare_v2).
Attached patch v1.0Splinter Review
I can't figure out how to get |hg qdiff| to get more lines of context (maybe it doesn't support -U for that yet), but I don't think it matters for this patch.

It's nice to remove code that is no longer needed :)
Assignee: nobody → sdwilsh
Status: NEW → ASSIGNED
Attachment #321448 - Flags: review?(shaver)
Whiteboard: [has patch][needs review shaver]
Comment on attachment 321448 [details] [diff] [review]
v1.0

r=shaver, though I'd be happier if you'd had to remove tests at the same time. :)
Attachment #321448 - Flags: review?(shaver) → review+
Whiteboard: [has patch][needs review shaver] → [has patch][has review][can land]
Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/index.cgi/rev/d48909ac2fa1
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [has patch][has review][can land]
You need to log in before you can comment on or make changes to this bug.