434341 - Installed files are not deleted when installation is canceled when it fails during file copy

Status: RESOLVED WONTFIX

(Firefox :: Installer, defect)

Description

[Serge Gautherie (:sgautherie)]

Noticed as a side-effect of bug 434338 case:

When I get the
{{
Error opening file for writing: ...\chrome\en-US.jar
}}
dialog,
I can Retry or Cancel.

If I cancel, the already copied files are left in the destination directory.
I had not enough space ... Now, I have even less (= "none").

Cancel should revert what was done so far.

Comment 1

[Serge Gautherie (:sgautherie)]

To be explicit:
*Files in temporary dir. are removed.
*Files in target dir. are not.

Comment 2

[Samuel Sidler (old account; do not CC)]

Weird, but an edge case. Not wanted for 1.9.0.x but let's see if we can get it looked at for 1.9.1.

Comment 3

[Robert Strong (they/them - no direct email)]

NSIS doesn't provide the functionality to accomplish this and I doubt we are going to implement this ourselves in NSIS especially for an edgecase that has only been reported when trying to make the installer fail under these conditions.

Comment 4

[Samuel Sidler (old account; do not CC)]

That sounds like WONTFIX to me, which would be perfectly fine...

Comment 5

[Robert Strong (they/them - no direct email)]

I'd rather leave this open in case a fix comes along.

btw: one way to fix this would be to implement MSI.

Comment 6

[Robert Strong (they/them - no direct email)]

All installers now support installing when files are in use so this should no longer happen is now WONTFIX