434348 - Shadows of tab labels are rendered incorrectly due to simple rules in my userChrome.css

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Corey Oordt]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9) Gecko/2008051202 Firefox/3.0
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9) Gecko/2008051202 Firefox/3.0

When a tab appears, the light gray shadow is rendered as if the font size is fractionally bigger and the shadow thus renders bigger than the label. 

Reproducible: Always

Steps to Reproduce:
1.Create more than one tab.

Actual Results:  
Rendering of shadow is bigger than that of label

Expected Results:  
Render of shadow is the same size as label

No extensions are enabled.
Mac OS X 10.5.2, MacBook Pro

Comment 1

[Corey Oordt]

Attachment: Image of the misrendering tab labels

Comment 2

[Corey Farwell]

Just to be safe, try Firefox in safe-mode:
http://support.mozilla.com/en-US/kb/Safe+Mode
Report your findings after

Comment 4

[Jesse Ruderman]

Do you guys (Corey and Dominique) have a userChrome.css file that might be altering the size of either the text label or its shadow?  I assume that's what was happening to the user in bug 427384.  Look for it in the chrome subdirectory of your Firefox profile.  In a stock profile, there will be a userChrome-example.css and a userContent-example.css, but no corresponding files without "-example".

FWIW, safe mode does not disable userChrome.css and userContent.css (see bug 333808).

Comment 5

[Jesse Ruderman]

It seems a little sketchy to me that ".tab-text" has a font specified, but its
sibling, ".tab-text-shadow", does not:

http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/browser/themes/pinstripe/browser/browser.css&rev=1.156&mark=1638-1646#1637

(DOM Inspector FTW.)

Comment 6

[Jesse Ruderman]

As a workaround, you can *create* a userChrome.css file containing:

.tab-text-shadow { display: none }

But it would be great if we also figured out the cause of the bug; it might be something that affects a lot of users and can be fixed.

Comment 7

[Dão Gottwald [:dao]]

(In reply to comment #5)
> It seems a little sketchy to me that ".tab-text" has a font specified, but its
> sibling, ".tab-text-shadow", does not:
> 
> http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/browser/themes/pinstripe/browser/browser.css&rev=1.156&mark=1638-1646#1637

Yeah, this could be it.

Comment 8

[Corey Oordt]

I did have a userChrome.css file. There wasn't much to it, but removing it fixed the issue. I'll attach a copy of the css file.

Comment 9

[Corey Oordt]

Attachment: userChrome.css file that when removed, fixed issue

Comment 10

[Jesse Ruderman]

Attachment: patch

I can reproduce the bug with Corey's userChrome.css.  This patch fixes Firefox to work correctly in that case, and doesn't seem to break the normal case.

Comment 11

[Kevin Gerich]

Nice catch Corey

Comment 12

[Al Billings [:abillings - ex-MoCo]]

Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b1pre) Gecko/20081002 Minefield/3.1b1pre.