Closed Bug 434496 Opened 16 years ago Closed 16 years ago

Login URL for experimental non-Firefox extension gets you to firefox extension page.

Categories

(addons.mozilla.org Graveyard :: Public Pages, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: nONoNonO, Assigned: wenzel)

References

()

Details

Attachments

(1 file)

When you want to download a non-firefox experimental extension you need to login. Aftre logging in you end up on the firefox install page, instead of getting the download or returning to the download page of the app you started with.

Reproducible: Probably Always

Steps to Reproduce:
1. Find an experimental non-firefox extension (mine is nominated to get public, chromedit is old and experimental, so may longer exist...)
   https://addons.mozilla.org/en-US/thunderbird/addon/7026
2. Click on the Download Now button or Login link
   https://addons.mozilla.org/en-US/thunderbird/users/login?to=%2Faddon%2F7026

Actual Results:
You end up on the firefox addon page https://addons.mozilla.org/en-US/firefix/addon/7026

Expected Results:
You return to the original URL https://addons.mozilla.org/en-US/thunderbird/addon/7026 (and it would be even better if your download would start immediately...)

Additional Info:
The bug was first documented on bug 431707 and might get solved with bug 429277 ...
Attached patch linkfixSplinter Review
Confirming, fixing.
Assignee: nobody → fwenzel
Status: NEW → ASSIGNED
Attachment #321596 - Flags: review?(fligtar)
OS: Windows XP → All
Hardware: PC → All
Thanks, that's a track record for my bugs :-)
Comment on attachment 321596 [details] [diff] [review]
linkfix

Cesar just volunteered to pick up this patch. Yay!

(Okay, I lied: I volunteered him during my evil five minutes).
Attachment #321596 - Flags: review?(fligtar) → review?(cdolivei.bugzilla)
Comment on attachment 321596 [details] [diff] [review]
linkfix

Looks good to me!
Attachment #321596 - Flags: review?(cdolivei.bugzilla) → review+
r13310. Thanks, all.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: push-needed
Resolution: --- → FIXED
Target Milestone: --- → 3.4.3
Works for me too when manually changing to login URL to
https://addons.mozilla.org/en-US/thunderbird/users/login?to=%2Fen-US%2Fthunderbird%2Faddon%2F7026

Thanks for fixing. Didn't know it could go that fast. Now let's wait for AMO 3.4.3

Still I don't understand the need for *me* to file it as a bug. Is it politeness or what? IMHO Philip Chee or wenzel could have done it just the same and save me the work. I'll take that question to news://news.mozilla.org/mozilla.support.bugzilla , since etiquette somewhere says I should...
(In reply to comment #6)
> Still I don't understand the need for *me* to file it as a bug. Is it
> politeness or what? IMHO Philip Chee or wenzel could have done it just the same
> and save me the work.

Ah, that was not meant to offend you; if it did, apologies. I could have filed it indeed, but it is somehow customary for the person who finds a bug to file it. If you comment on a different bug mentioning a problem that's not related to the bug in question, people usually ask you to file it as a separate bug. If it's any consolation, that happens to me too on occasion :)
No offense taken. I thought it would be out of custom. My problem with this custom is, that you rely on the responsibility of the other to file the bug. If I wouldn't have filed it, the bug could have been there longer than necessary.

I know I still need to file a bug about being able in an extension to change keyboard shortcuts (accesskey) on the fly, where the menuitems don't get updated. I have asked about this on project_owners@mozdev.org, because I couldn't get it to work, and was also suggested to file it as a bug. The person who suggested that, mentioned he even had a possible patch for it. 
Verified FIXED, substituting preview.* links for the production ones in comment 0 (with different, but sandboxed, Thunderbird add-ons).  Thanks Onno!
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: