Assignee: nobody → nelson
Severity: major → blocker
Priority: -- → P1
Target Milestone: --- → 0.6
Created attachment 321667 [details] [diff] [review] is this filtering enough?
Attachment #321667 - Flags: review?(laura)
A couple of comments on the attached patch: 1) you probably don't need to re-assign $_REQUEST["error"] as its escaped self since you are later displaying it using the same escaping functions. 2) a better approach for this type of page would be to have a set of pre-determined error messages that can be chosen from by specifying an error ID in the URL. This is better than echoing a string that an attacker can easily modify. The patch as attached will fix the present issue, though. Just my 0.02.
Comment on attachment 321667 [details] [diff] [review] is this filtering enough? Looks good to me. Please commit ASAP.
Attachment #321667 - Flags: review?(laura) → review+
This was pushed in https://bugzilla.mozilla.org/show_bug.cgi?id=434670
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Group: webtools-security → websites-security
Status: RESOLVED → VERIFIED
Adding keywords to bugs for metrics, no action required. Sorry about bugmail spam.
These bugs are all resolved, so I'm removing the security flag from them.
You need to log in before you can comment on or make changes to this bug.