434592 - url-classifier should be enabled by default on xulrunner

Status: RESOLVED FIXED

(Toolkit Graveyard :: XULRunner, defect)

Description

[Mike Hommey [:glandium]]

When building against a "standard" libxul-sdk, which doesn't include the url-classifier component (which lives in toolkit/components and isn't enabled by default), safe browsing doesn't work because of lack of the url-classifier (since stuff in toolkit/components don't get included, even though url-classifier ends up being enabled during the build)

Either the url-classifier should be enabled by default in libxul builds, or it should either be moved in browser or built in some way from toolkit even when using a libxul-sdk.

Comment 1

[Reed Loden [:reed]]

Yes, this is pretty bad... I just noticed yesterday that Ubuntu has disabled safe browsing because of problems like this. :/

Comment 2

[Mike Hommey [:glandium]]

FWIW, I'm going to enable url-classifier in xulrunner in Debian to solve this issue.

Comment 3

[Christopher Aillon (sabbatical, not receiving bugmail)]

FWIW, safe browsing works in Fedora's builds.  We're doing --enable-safe-browsing in both XR and FF, which might be the magic to make it work.

Comment 4

[Mike Connor [:mconnor]]

this is a distro config issue for now, it might not be ideal, but we're not going to rearchitect stuff.

Comment 5

[Mike Hommey [:glandium]]

It's not necessarily about rearchitect stuff. It could be changing defaults, i.e. activating uri-classifier on xulrunner by default.

Comment 6

[Mike Hommey [:glandium]]

Attachment: Enable url-classifier by default on xulrunner

Comment 7

[Benjamin Smedberg]

Comment on attachment 513410 [details] [diff] [review]
Enable url-classifier by default on xulrunner

I think this is fine. It's separate from whether we enable safebrowsing by default, which might require partner input.

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Kev: opinions? I'm for this, generally, but want to make sure we're not pooching folks.

Comment 9

[Kev Needham [:kev]]

I don't see any issue, as it's something that doesn't affect our default builds, and I can't see it being a deal-breaker as it can still be turned off. Definitely something that'll need some documentation/messaging love for where it might affect orgs who are compiling their own binaries (which is primarily distros and projects such as Powered-by-Mozilla) from the various distros.

I don't know of anyone it'd pooch off-hand, but we don't have visibility into what other folks do with our source, and we should make sure this change is documented.

Comment 10

[Johnathan Nightingale [:johnath]]

Comment on attachment 513410 [details] [diff] [review]
Enable url-classifier by default on xulrunner

Hrm - Mike - I think we have to minus this - wouldn't each app need to work out it's own downstream T&C with google for the use of the safebrowsing service? I don't think our agreement covers that. I suspect you are covered, but not "any xulrunner app"

Comment 11

[Mike Hommey [:glandium]]

(In reply to comment #10)
> Comment on attachment 513410 [details] [diff] [review]
> Enable url-classifier by default on xulrunner
> 
> Hrm - Mike - I think we have to minus this - wouldn't each app need to work out
> it's own downstream T&C with google for the use of the safebrowsing service? I
> don't think our agreement covers that. I suspect you are covered, but not "any
> xulrunner app"

Hum, this is url-classifier, not safebrowsing. Not that if you are concerned with downstream T&C for safebrowsing, bug 557752 is the one to address.

(In reply to comment #9)
> I don't see any issue, as it's something that doesn't affect our default
> builds, and I can't see it being a deal-breaker as it can still be turned off.
> Definitely something that'll need some documentation/messaging love for where
> it might affect orgs who are compiling their own binaries (which is primarily
> distros and projects such as Powered-by-Mozilla) from the various distros.

Note that a lot of distros shipping firefox as a xulrunner application already enable url-classifier in xulrunner (by hand).

Comment 12

[Mehdi Mulani [:mmm] (I don't check this)]

url-classifier does look up hashes through Google, at least in the default config of Firefox:
http://mxr.mozilla.org/mozilla-central/source/browser/app/profile/firefox.js#729

Comment 13

[Mike Hommey [:glandium]]

(In reply to comment #12)
> url-classifier does look up hashes through Google, at least in the default
> config of Firefox:
> http://mxr.mozilla.org/mozilla-central/source/browser/app/profile/firefox.js#729

And this bug changes the default in xulrunner, and xulrunner doesn't set these prefs.

Comment 14

[Benjamin Smedberg]

Comment on attachment 513410 [details] [diff] [review]
Enable url-classifier by default on xulrunner

renoming for the triage meeting

Comment 15

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 513410 [details] [diff] [review]
Enable url-classifier by default on xulrunner

a=beltzner

Comment 16

[Mike Hommey [:glandium]]

http://hg.mozilla.org/mozilla-central/rev/4653a9f58761