Closed
Bug 434620
Opened 17 years ago
Closed 17 years ago
invalid_field_name and product_edit_denied have the same error ID
Categories
(Bugzilla :: WebService, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.2
People
(Reporter: mkanat, Assigned: dkl)
Details
Attachments
(1 file, 1 obsolete file)
|
1.01 KB,
patch
|
mkanat
:
review+
|
Details | Diff | Splinter Review |
In Bugzilla::WebService::Constants, invalid_field_name and product_edit_denied are both error 108. This is because somebody put invalid_field_name way up next to the "103" errors, so nobody noticed the ID conflict when adding a new one.
Flags: blocking3.2+
|
||
Updated•17 years ago
|
Target Milestone: --- → Bugzilla 3.2
|
Assignee | |
Comment 1•17 years ago
|
||
Attaching patch to move product_edit_denied error code from 108 to 109 to remove conflict with invalid_field_name.
Please review.
Dave
|
|
Reporter | |
Comment 2•17 years ago
|
||
Comment on attachment 325433 [details] [diff] [review]
Patch to fix product_edit_denied error code conflict (v1)
Also move the 108 error into the right place so that this doesn't happen again.
Attachment #325433 -
Flags: review?(mkanat) → review-
|
|
Assignee | |
Comment 3•17 years ago
|
||
Moved the 108 error code down to be in order with the other codes.
Please review.
Thanks
Dave
Attachment #325433 -
Attachment is obsolete: true
Attachment #325574 -
Flags: review?(mkanat)
|
|
Reporter | |
Updated•17 years ago
|
Attachment #325574 -
Flags: review?(mkanat) → review+
|
|
Reporter | |
Updated•17 years ago
|
Flags: approval3.2+
Flags: approval+
|
|
Assignee | |
Comment 4•17 years ago
|
||
tip:
Checking in Bugzilla/WebService/Constants.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/WebService/Constants.pm,v <-- Constants.pm
new revision: 1.18; previous revision: 1.17
done
3.2:
Checking in Bugzilla/WebService/Constants.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/WebService/Constants.pm,v <-- Constants.pm
new revision: 1.16.2.1; previous revision: 1.16
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•