434623 - Login dialog asks for pass phrase even if encryption is set to none

Status: RESOLVED FIXED

(Cloud Services :: General, defect, P1)

Description

[Anant Narayanan [:anant]]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_2; en-us) AppleWebKit/525.18 (KHTML, like Gecko) Version/3.1.1 Safari/525.18
Build Identifier: Mercurial tip

If the preference extensions.weave.encryption is set to "none", the login dialog displays a javascript alert box "You must enter a passphrase", even though a textbox for the passphrase was (correctly) not displayed.

Reproducible: Always

Steps to Reproduce:
1. Set the extensions.weave.encryption preference to "none"
2. Try to login
Actual Results:  
Javascript alert box "You must enter a passphrase" appears

Expected Results:  
Login proceeds without displaying the alert box

Comment 1

[Anant Narayanan [:anant]]

Attachment: Don't ask for passphrase if encryption is set to "none"

The user is no longer prompted for a passphrase if encryption is set to "none". Login, however, still fails due to bug #434625

Comment 2

[Dan Mills [:thunder]]

Comment on attachment 321873 [details] [diff] [review]
Don't ask for passphrase if encryption is set to "none"

Looks good!

Comment 3

[Anant Narayanan [:anant]]

Checked-in revision 340