Closed Bug 434675 Opened 15 years ago Closed 15 years ago

Kinetic Scrolling/Panning

Categories

(Firefox for Android Graveyard :: Panning/Zooming, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: dougt, Assigned: dougt)

Details

Attachments

(1 file)

 
Attached patch patch v.1Splinter Review
Attachment #321805 - Flags: review?(mark.finkle)
Comment on attachment 321805 [details] [diff] [review]
patch v.1

need to figure out just the right values.

1) removed the aEvent from startPan, doPan, endPan.  Since I am now calling doPan directly, i didn't want to pass null, so I just removed the unneeded call.

2) added comments around magic numbers to remind ourselves to figure out what the best values actually are.

3) in doPan(), if the total distance we have dragged is greater than 250 (need to figure out the right value), we force an update to the canvas.
Comment on attachment 321805 [details] [diff] [review]
patch v.1

looks pretty good
Attachment #321805 - Flags: review?(mark.finkle) → review+
Comment on attachment 321805 [details] [diff] [review]
patch v.1

thanks.  the feature still needs alot of tweaking, but this is the right foundation.
checked in.  lets file new bugs against specific bustages/improvements.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
this has been in for a while and verified with beta3
Status: RESOLVED → VERIFIED
Component: General → Panning/Zooming
You need to log in before you can comment on or make changes to this bug.