Closed Bug 434745 Opened 13 years ago Closed 6 years ago

improve palmsyncinstall.exe feedback when conduit installation/registration fails

Categories

(MailNews Core Graveyard :: Palm Sync, enhancement)

x86
Windows XP
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: wsmwk, Unassigned)

References

(Blocks 1 open bug)

Details

David, Mark - need your advice about http://lxr.mozilla.org/mozilla/source/mailnews/extensions/palmsync/installer/PalmSyncInstall.cpp

this bug is about when conduit fails to register/install when running palmsyncinstall.exe.  As in bug 330819 and bug 422494 comment 3, better feedback would make it easier to solve problems. 

palmsyncinstall.exe of course is a standalone program running outside of thunderbird - so not able to do what we did in Bug 373404 – improve palmsync error checking and logging, and feedback to the hotsync manager

Starting with bug 422494 comment 3 - what form of feedback might be best - logging, different error codes based on where we're at in the code, a dialog with text?  I'd prefer to always give the user better feedback, i.e. not require some debugging switch. 

1. Add logging to a disk as was done in the conduit
   https://bugzilla.mozilla.org/show_bug.cgi?id=189140#c3

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=MozABConduitSync.cpp&branch=&root=/cvsroot&subdir=mozilla/mailnews/extensions/palmsync/conduit&command=DIFF_FRAMESET&rev1=1.1&rev2=1.2

2. add windows dialogue boxes at key points to display 'data', like in
http://lxr.mozilla.org/mozilla/source/mailnews/extensions/palmsync/installer/PalmSyncInstall.cpp#198
 198 ConstructMessage(hInstance, appName, IDS_APP_TITLE_INSTALL, appTitle);
 199 ConstructMessage(hInstance, appName, IDS_CONFIRM_INSTALL, msgStr);

#3 other?


OT question - why does palmsyncinstall.cpp have no constructor and destructor - what it just a style decision?


Summary of related bugs ...
- Bug 182573 – Mozilla PalmSync Install failure message "Error in loading the Conduit Manager" [suite]
- Bug 234391 – "Conduit Error: Unknown error (110C)" or "retval=4364" in hot sync log or conduit log - nothing happens syncing Palm Address Book to Thunderbird because conduit did not successfully install via palmsyncinstall.exe ... but some of those people's issues were presumably resolved by bug 234391 comment 7, so picking up the remaining problem here
- Bug 330819 – failed to register mozilla's palm sync support dll while installing mozilla address book palm sync conduit
- Bug 422494 – PalmSync (v. 2.0.0 beta) will not install into new Palm Desktop 6.2 with HotSync Manager 7.0.2 (edit)
Palmsyncinstall.cpp doesn't define any c++ objects, hence there's no constructor or destructor.

Windows dialog boxes for error feedback would be OK, though that would bring up the localization of strings question. I'm not sure how that's done for palmsyncinstall.cpp since it's really a Windows app, not a Mozilla app.

An other possibility would be for PalmSyncinstall.cpp to somehow communicate errors back to TB/SM - perhaps through setting registry strings or writing a file to disk. But that can be messy.
(In reply to comment #1)

> Windows dialog boxes for error feedback would be OK, though that would bring up
> the localization of strings question. I'm not sure how that's done for
> palmsyncinstall.cpp since it's really a Windows app, not a Mozilla app.

Since there are no localized "versions" of palmsync, palmsyncinstall would not be affected AFAIK.  And if, as we have specified, palmsync is NPOTB, then the rest of thunderbird is unaffected.  No?


> An other possibility would be for PalmSyncinstall.cpp to somehow communicate
> errors back to TB/SM - perhaps through setting registry strings or writing a
> file to disk. But that can be messy.

Not liking that idea either, however we may need some change there anyway if palmsync is enabled in addons after palminstall fails. ref: bug 422494 comment 6 ...
Blocks: 374151
Product: Core → MailNews Core
QA Contact: vseerror → palm-sync
Product: MailNews Core → MailNews Core Graveyard
Assignee: bienvenu → nobody
This bug has been buried in the graveyard and has not been updated in over 5 years. It is probably safe to assume that it will never be fixed, so resolving as WONTFIX.

[Mass-change filter: graveyard-wontfix-2014-09-24]
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.