Closed
Bug 434768
Opened 17 years ago
Closed 17 years ago
try server needs to use max_builds= rather than SlaveLock
Categories
(Release Engineering :: General, defect, P3)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bhearsum, Assigned: bhearsum)
Details
Attachments
(1 file)
2.04 KB,
patch
|
coop
:
review+
|
Details | Diff | Splinter Review |
As we discovered with the Mozilla2 Buildbot, SlaveLock does not actually limit one build per slave, max_builds= (as a parameter to BuildSlave()) does this. While testing out hg builds on the try server I noticed that try server is still using SlaveLock and incorrectly queueing builds.
Assignee | ||
Updated•17 years ago
|
Priority: -- → P3
Assignee | ||
Comment 1•17 years ago
|
||
I've added max_builds parameters to BuildSlaves.py on the master already, with these removed each slave should be able to build without blocking stupidly on an unrelated builder.
Attachment #322125 -
Flags: review?(rcampbell)
Assignee | ||
Comment 2•17 years ago
|
||
Comment on attachment 322125 [details] [diff] [review]
remove SlaveLocks from tryserver master.cfg
Any chance you can get to this soon?
Assignee | ||
Updated•17 years ago
|
Attachment #322125 -
Flags: review?(rcampbell) → review?(ccooper)
Updated•17 years ago
|
Attachment #322125 -
Flags: review?(ccooper) → review+
Assignee | ||
Updated•17 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•