try server needs to use max_builds= rather than SlaveLock

RESOLVED FIXED

Status

P3
normal
RESOLVED FIXED
11 years ago
5 years ago

People

(Reporter: bhearsum, Assigned: bhearsum)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

As we discovered with the Mozilla2 Buildbot, SlaveLock does not actually limit one build per slave, max_builds= (as a parameter to BuildSlave()) does this. While testing out hg builds on the try server I noticed that try server is still using SlaveLock and incorrectly queueing builds.
(Assignee)

Updated

11 years ago
Priority: -- → P3
(Assignee)

Comment 1

11 years ago
Created attachment 322125 [details] [diff] [review]
remove SlaveLocks from tryserver master.cfg

I've added max_builds parameters to BuildSlaves.py on the master already, with these removed each slave should be able to build without blocking stupidly on an unrelated builder.
Attachment #322125 - Flags: review?(rcampbell)
(Assignee)

Comment 2

11 years ago
Comment on attachment 322125 [details] [diff] [review]
remove SlaveLocks from tryserver master.cfg

Any chance you can get to this soon?
(Assignee)

Updated

11 years ago
Attachment #322125 - Flags: review?(rcampbell) → review?(ccooper)
Attachment #322125 - Flags: review?(ccooper) → review+
(Assignee)

Updated

11 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.