435088 - Check .autoreg in the GRE directory, too

Status: RESOLVED FIXED

Description

[Mike Hommey [:glandium]]

Created attachment 321999 [details] [diff] [review]
patch

When using xulrunner applications, xpcom current process directory and GRE directory are different, and may contain things that are not updated synchronously, and one may need to trigger autoregistration of components on update of one or the other.

The attached patch implements checking in both GRE_DIR and XPCOM_CURRENT_PROCESS_DIR (skipping second check when it is the same directory).

Comment 1

[Benjamin Smedberg]

What failure case are you trying to solve? XR apps should be blowing away all component registration whenever the buildid of the toolkit or the application changes, see http://mxr.mozilla.org/mozilla/source/toolkit/xre/nsAppRunner.cpp#2135

Comment 2

[Mike Hommey [:glandium]]

In debian, and maybe in other linux distributions, we separate some components and put them in different packages (such as pyxpcom or mozgnome) to avoid spurious dependencies. When installing these extra components (that can't really be put as extensions, because not all applications enable the extensions manager, but we want all applications to have these components available, and for pyxpcom, it's actually mandatory), we trigger components autoregistration by touching .autoreg. The buildid doesn't change since we install new components on the same build.

Comment 3

[Reed Loden [:reed] (use needinfo?)]

http://hg.mozilla.org/mozilla-central/rev/49b6ae6afcc4