435094 - Buttons on Weave's login dialog do nothing, if I didn't enter my Master Password

Status: RESOLVED WORKSFORME

(Cloud Services :: General, defect)

Description

[Daniel Holbert [:dholbert]]

Steps to reproduce:
1. Log in to Weave add-on.  Make sure it's configured to store your Weave passwords.
2. Set a Master Password on Firefox. (Preferences, Security, 'Use Master Password')
3. Click on Weave button in status bar, and "Sign Out" (if necessary)
4. Click on Weave button in Status bar, and choose "Sign In"
  ==> Master Password dialog appears
5. Click 'Cancel' on Master Password dialog
  ==> Mozilla Services Login dialog appears, with blank password fields
6. Click 'Cancel' on Mozilla Services Login dialog

EXPECTED RESULTS:
 Dialog should disappear, and I should stay logged out of Weave.

ACTUAL RESULTS:
 Dialog stays there -- 'cancel' appears to do nothing at all.
 The 'OK' button also does nothing.
 The 'Esc' key also does nothing.
The only way to dismiss the dialog is to click its 'close' button in the upper-right corner.

This is particularly annoying because the dialog is modal, so I can't use Firefox while the dialog is up.

Note that if I *don't* have a master password set up, or if I have one and I enter it, then this all works correctly.  (the 'OK' and 'Cancel' buttons and the 'Esc' key work as expected on the weave login dialog.)

Version info:
 Weave 0.1.29
 Firefox 3rc1
 Ubuntu Linux 8.04

Comment 1

[Dan Mills [:thunder]]

Punting to 0.3.

Comment 2

[Dan Mills [:thunder]]

Downgrading severity to 'normal', since it doesn't cause any permanent damage and there is a workaround.

Comment 3

[Dan Mills [:thunder]]

These bugs need to be triaged, removing 0.3 milestone setting.

Comment 4

[Dan Mills [:thunder]]

Moving to needs triage component.  Not sure if this is still a problem, please verify?

Comment 5

[Daniel Holbert [:dholbert]]

Not a problem anymore.  In particular, the final step of STR is no longer applicable, because there's no "Mozilla Services Login dialog" anymore.