435103 - Weave auto-connects whenever I open a new window, not just when Firefox starts

Status: VERIFIED FIXED

(Cloud Services :: General, defect)

Description

[Daniel Holbert [:dholbert]]

Weave has a preference to "automatically connect each time I start Firefox".

However, it looks like this is currently implemented in such a way as to automatically try to connect **each time I open a new window** in Firefox, rather than just once at application start-time.

Steps to reproduce:
  1. Set up Weave to automatically connect when you start Firefox (as described in bug 435100)
  2. Click weave icon in status bar, and choose "Sign Out"
    ==> Weave status changes from "Idle" to "Offline"
  3. Ctrl-N to open a new window. (or shift-click a link)

ACTUAL RESULTS:
  Weave status changes from "Offline" back to "Idle", indicating that it's now logged me in.

EXPECTED RESULTS:
  Weave should respect my decision to be offline, and shouldn't log me back in every time I open a new window.

This bug is particularly annoying in combination with bug 435100 -- if I'm using a Master Password, and I haven't entered it yet, then I get a "Please enter the master password" dialog **every time I open a new window**.  (because Weave tries to access my information to auto-connect)

Version info:
 Weave 0.1.29
 Firefox 3rc1
 Ubuntu Linux 8.04

Comment 1

[Atul Varma [:atul]]

Fixed: http://hg.mozilla.org/labs/weave/index.cgi/rev/fb2f4efd73d3

Comment 2

[Daniel Holbert [:dholbert]]

Verified fixed in Weave v0.1.30.  Thanks for fixing this!