435113 - audit cgis in old and new repos to ensure consistency

Status: RESOLVED FIXED

(Webtools Graveyard :: Graph Server, defect)

Description

[alice nodelman [:alice] [:anode]]

The copy of graphs/server/getdata.cgi in hg has a non-operational copy of getdata.cgi (it contains a bad sql query that breaks).

The problem hasn't been noticed yet because our currently up versions of the new graph server front end uses the old cvs code for accessing the database - nobody is currently using the new hg db interaction code.

A fresh copy should be pulled from cvs to replace the broken version and get us back to a working state.

Comment 1

[alice nodelman [:alice] [:anode]]

Looking over this, I think that there are also changes to bulk.cgi/collect.cgi/graphsdb.py that are only in cvs and not in hg.  We need to get this server code lined up so that we'll be able to run a standalone version of the hg code without having to intermix bits and pieces of cvs server code.

Comment 2

[Ryan Doherty (:rdoherty)]

Attachment: fix for getdata.cgi

Here's the fix for getdata.cgi

Comment 3

[Laura Thomson :laura]

Note: rdoherty's fix has been committed (by alice I presume).  At least it's in hg.

Comment 4

[Laura Thomson :laura]

On review, the remainder of the differences are around the change in link format, and new additions to hg.  Calling this done.