43512 - Crash on startup using a read-only filesystem

Status: VERIFIED FIXED

(Core :: XPCOM, defect, P3)

Description

[rusty.lynch]

Even if you rip out the code to auto-register components and rebuild the 
interface manifest, mozilla/viewer will crash if the filesystem is not writable.

The reason for this is that the code in reg.c attempts to open the registry as 
read/write, and then attempts to do the right thing if the open fails with an 
access error by attempting a read-only open.  The only problem is that the case 
statement attempts to explicitly catch each type of failure but doesn't 
consider the nspr wrapped EROFS error for read-only filesystem.

I will be attaching a patch.

Comment 1

[rusty.lynch]

Attachment: patch for mozilla/modules/libreg/src/reg.c

Comment 2

[qaz2]

adding crash keyword

Comment 3

[Decklin Foster]

*** This bug has been marked as a duplicate of 33344 ***

Comment 4

[Decklin Foster]

My apologies, marked this too soon. Reopening.

Comment 5

[rusty.lynch]

dveditz,

I see your name on all the recent check-ins to reg.c.  Will you review my patch?

Comment 6

[Daniel Veditz [:dveditz]]

Looks ok to me, r=dveditz

We really need to change the API so it takes a flag on whether read-only is OK 
or if writing is required. That change would have to percolate all the way up 
through nsIRegistry and into all client users so it's a bit outside the scope 
of what we can tackle right now.

Comment 7

[rusty.lynch]

patch checked in.

Comment 8

[Tracy Walker [:tracy]]

please verify

Comment 9

[leger]

Marking Verified.  Please reopen if problem reoccurs.