435423 - Upgrade search

Status: RESOLVED INVALID

(Webtools Graveyard :: Party Tool, defect)

Description

[Alex Buchanan [:abuchanan]]

on events/index, type a search in the search box, get...

Illegal offset type [APP/controllers/events_controller.php, line 67]

Comment 1

[Alex Buchanan [:abuchanan]]

this could be a minor bug, as search works on the stage site

Comment 2

[Alex Buchanan [:abuchanan]]

yep search is definitely broken...

try searching using the "parties within 20 miles of...etc" option.

breaks horribly, glad we found this before launch :)

this has to do with the Google geocoder I assume, we'll probably have to remove this advanced search option for launch this week, and add it in the next maintenance round. 

Comment 3

[Alex Buchanan [:abuchanan]]

commented out broken options for launch, r13910

Comment 4

[Alex Polvi]

now when you search it just returns a page that says "search" ... no search results.

http://mozillaparty.com/en-US/events/

Comment 5

[Alex Buchanan [:abuchanan]]

r14177 fixes broken search 

problem was escape(array) isn't valid (or is deprecated), 
use clean($array, array('escape')) instead

Comment 6

[Alex Buchanan [:abuchanan]]

morphing for future enhancements.

not sure if we want to do this by 2.2, but a better search seems useful.

(just ideas) we could.. 
  -bring back commented out for launch
  -add new options
     -biggest, or most popular, or where da party at? so to speak :)
     -make the search bar prettier, right now is doesn't have any styling
        -CSS++
        - a drop down for number of results

also, sort by newest/oldest doesn't work

Comment 8

[Alex Buchanan [:abuchanan]]

Attachment: upgrade search v1

greatly upgrades search.  fixes "sort by", adds back location search, better styling (IMO), searches persist over pagination/re-search

Comment 9

[Alex Polvi]

ryan, could we get the review?

Comment 10

[Alex Buchanan [:abuchanan]]

committed to trunk/ in r17269

Comment 11

[Alex Buchanan [:abuchanan]]

un-assigning myself as I haven't worked on this project lately, and probably won't in the very near future

Comment 12

[Alex Buchanan [:abuchanan]]

Closing old bugs.  This website doesn't exist anymore