435443 - Pop-up login window has old version of password dialog, not the new infobar

Status: RESOLVED INCOMPLETE

(Toolkit :: Password Manager, defect)

Description

[Deb Richardson [:dria] (plz NEEDINFO)]

To replicate this: 

1. Get RC1 and go here https://addons.mozilla.org/en-US/firefox/addon/5457 .
2. Install that then go to a page and select "twitter this" from the Shareaholic button menu.  
3. This pops up a window to log into twitthat.com.  Log in.
4. Notice that the "remember this password" dialog is the old-style Fx2 dialog, not the new and ultra-sexy Fx3 infobar dropdown.

Comment 1

[Justin Dolske [:Dolske]]

Offhand I'd guess the extension is making a XHR with authentication, the code can't associate that with a window (tab), and so it falls back to using the old-style prompt.

Any errors with http://wiki.mozilla.org/Firefox:Password_Manager_Debugging ?

Comment 2

[:Gavin Sharp [email: [e-mail]]]

[23 09:17:47] <gavin> I think I know why this is happening
[23 09:18:00] <gavin> the "opener" in this case is the chrome window where the extension button is
[23 09:18:04] <gavin> rather than a content window
[23 09:18:14] <gavin> so our magic for finding the right opener is broken

I confirmed that we hit:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/components/passwordmgr/src/nsLoginManagerPrompter.js&mark=910#880

but end up returning null from _getNotifyBox, without an exception being thrown, so my theory is that getBrowserForDocument() is returning null because notifyWindow.document is a chrome doc.

Comment 3

[Justin Dolske [:Dolske]]

Hmm. I guess we could add a check there to ignore window.opener if it's chrome. Alternatively, should .opener even be getting set in this case?

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Actually I'm beginning to doubt my theory, because this._window should be a content window, right? It shouldn't have a chrome opener. Need to look into this further.

Comment 5

[Matthew N. [:MattN]]

With e10s I think the STR would even more rare.