Closed Bug 435462 Opened 16 years ago Closed 16 years ago

nsIMsgFolder::getChildNamed should return nsIMsgFolder not nsISupports

Categories

(MailNews Core :: Backend, defect)

Product:
MailNews Core
Component:
Backend
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla1.9

People

(Reporter: standard8, Assigned: standard8)

Details

(Keywords: memory-footprint)

Attachments

(2 files)

The fix (diff -w)
10.98 KB, patch
Bienvenu
: review+
Bienvenu
: superreview+
Details | Diff | Splinter Review
The fix (full patch)
10.41 KB, patch
Details | Diff | Splinter Review 
nsIMsgFolder::getChildNamed currently returns an nsISupports item, rather than an nsIMsgFolder, this is causing us extra QI and code that we just don't need.

Patch and unit test attached.
Attachment #322273 - Flags: superreview?(bienvenu)
Attachment #322273 - Flags: review?(bienvenu)

    
  

        Attachment #322273 -
        Flags: superreview?(bienvenu)

        Attachment #322273 -
        Flags: superreview+

        Attachment #322273 -
        Flags: review?(bienvenu)

        Attachment #322273 -
        Flags: review+

    
    

    
  
Patch checked in -> fixed.
Status: NEW → RESOLVED
Closed: 16 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9
Product: Core → MailNews Core

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: