435504 - Boolean charts use field descriptions from the DB, making them english only

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Frédéric Buclin]

Attachment: patch, v1

In l10n installations, field descriptions of fields are always in english because field.description is displayed instead of field_descs.${field.name}.

Comment 1

[Max Kanat-Alexander]

Comment on attachment 322313 [details] [diff] [review]
patch, v1

>Index: template/en/default/search/boolean-charts.html.tmpl
>+              [% field_descs.${field.name} || "---" FILTER html %]

 Why || '---' instead of || field.description? Also, are you sure the html filter is filtering that whole statement and not just the second half?

Comment 2

[Frédéric Buclin]

(In reply to comment #1)
>  Why || '---' instead of || field.description? Also, are you sure the html
> filter is filtering that whole statement and not just the second half?

1) "---" is because the "noop" pseudo-field is the only one which is not a real field in the DB, and its description is "---". But I can write field.description is you prefer.

2) About FILTER html, I checked and it filters the whole thing correctly. Without it, I manage to inject JS alerts (by hacking one field description).

Comment 3

[Frédéric Buclin]

Should go into 3.2, and even in 3.0 IMO. Reading "Assignee" "est égal à" is crazy (first string in english, second one in french. Looks really unprofessionnal).

Comment 4

[Max Kanat-Alexander]

Comment on attachment 322313 [details] [diff] [review]
patch, v1

This is fine, but replace "---" with field.description.

Comment 5

[Frédéric Buclin]

At least in the french templates, not all field descriptions have been translated in field-descs.none.tmpl, meaning that boolean charts now mix both french and english field descriptions. I suppose other l10n packs are in the same situation. So I suggest SnowyOwl to advertise other localizers about it (3.2 and 4.0 only).

tip:

Checking in template/en/default/filterexceptions.pl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/filterexceptions.pl,v  <--  filterexceptions.pl
new revision: 1.113; previous revision: 1.112
done
Checking in template/en/default/search/boolean-charts.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/boolean-charts.html.tmpl,v  <--  boolean-charts.html.tmpl
new revision: 1.18; previous revision: 1.17
done


3.1.4:

Checking in template/en/default/filterexceptions.pl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/filterexceptions.pl,v  <--  filterexceptions.pl
new revision: 1.111.2.1; previous revision: 1.111
done
Checking in template/en/default/search/boolean-charts.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/boolean-charts.html.tmpl,v  <--  boolean-charts.html.tmpl
new revision: 1.17.2.1; previous revision: 1.17
done

Comment 6

[Vitaly Fedrushkov]

(In reply to comment #5)
> At least in the french templates, not all field descriptions have been
> translated in field-descs.none.tmpl, 

Why?  Definitely a flaw in l10n ;-)

See 

http://bugzilla-ru.svn.sourceforge.net/viewvc/bugzilla-ru/bugzilla-ru/template/ru/default/global/field-descs.none.tmpl?view=markup#l_70

for list of translatable [pseudo-]fields.

> So I suggest SnowyOwl to advertise other localizers about it

Will check others and notify.  Kindly add 'intl' keyword :-)

Comment 7

[Vitaly Fedrushkov]

Confirmed for: be, bg, cs, de, fr, nl, pl, zh-tw

Comment 8

[Vitaly Fedrushkov]

field-descs.none.tmpl is extended in bug 435570