435505 - Mac non-sheet modal dialogs should not show any buttons on the title-bar.

Status: RESOLVED WORKSFORME

(Core :: Widget: Cocoa, defect, P2)

Description

[Nick Kreeger]

Attachment: Safari Modal Dialog SS

Currently, the modal dialogs show disabled close, minimize, and zoom buttons for modal dialogs. These disabled buttons should be hidden to enhance appearance. 

See screenshots for comparison.

Comment 1

[Nick Kreeger]

Attachment: Firefox Modal Dialog SS

Comment 2

[Nick Kreeger]

Attachment: Patch V1

Proposed patch.

Comment 3

[Josh Aas]

Comment on attachment 322319 [details] [diff] [review]
Patch V1

Are we sure that this won't result in modals coming up that can't be closed? I'm worried about cross platform apps that assume they don't need to put close UI within the modal dialog. Windows Vista, at least, has a close button. I'd be more comfortable with this patch if it only hid minimize and maximize.

Comment 4

[Nick Kreeger]

(In reply to comment #3)
> (From update of attachment 322319 [details] [diff] [review])
> Are we sure that this won't result in modals coming up that can't be closed?
> I'm worried about cross platform apps that assume they don't need to put close
> UI within the modal dialog. Windows Vista, at least, has a close button. I'd be
> more comfortable with this patch if it only hid minimize and maximize.
> 

Sure that sounds good - but I should note that currently the maximize button (or any other button) is currently _always_ disabled. So I suggest that we leave that button enabled where we start doing all the sudo-modal configuration for the cocoa window. 

Does this sound OK Josh?

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #3)
> Are we sure that this won't result in modals coming up that can't be closed?
> I'm worried about cross platform apps that assume they don't need to put close
> UI within the modal dialog. Windows Vista, at least, has a close button.

From Nick's screenshot, Safari faces the same issue and apparently seems to believe it's a non-issue.

> I'd be
> more comfortable with this patch if it only hid minimize and maximize.

They either need to all be there (disabled if not applicable), or all not be there; mix-and-match hiding is against the HIG: http://developer.apple.com/documentation/UserExperience/Conceptual/OSXHIGuidelines/XHIGWindows/chapter_18_section_4.html#//apple_ref/doc/uid/20000961-SW34

Comment 6

[Josh Aas]

Comment on attachment 322319 [details] [diff] [review]
Patch V1

At the very least we need to unhide the standard buttons on the native window when a modal dialog goes away in case the window is used again non-modally.

If you save a page in Firefox you get a native modal save window (ignore whether or not that should be a sheet) and the window allows maximizing - the other two buttons to the left are disabled (not hidden). I think we're going to need a more complex solution - maybe disable close and minimize for modal dialogs, leave maximize enabled by default and if the XUL app disables maximize then totally hide all 3 buttons for the modal session.

Comment 7

[Tracy Walker [:tracy]]

This WFM on latest Nightly 49.0a1, 20160518030234