Closed
Bug 435546
Opened 16 years ago
Closed 16 years ago
SM: return without JS_POP_TEMP_ROOT in js_OnUnknownMethod
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: igor, Assigned: igor)
References
Details
Attachments
(1 file)
|
1.06 KB,
patch
|
brendan
:
review+
shaver
:
approval1.9+
|
Details | Diff | Splinter Review |
My fix for bug 355258 introduced a regression in js_OnUnknownMethod: the method got early return after failed js_IsFunctionQName. That would lead to the missing JS_POP_TEMP_ROOT on out-of-memory. The static analyzer for the control flow discovered this bug, see bug 432915.
|
Assignee | |
Comment 1•16 years ago
|
||
The fix added the missing goto.
|
||
Comment 2•16 years ago
|
||
Comment on attachment 322345 [details] [diff] [review] fix v1 Should go into .next -- guess that means into jsinterp.cpp in mozilla-central when it is open. /be
Attachment #322345 -
Flags: review?(brendan) → review+
3.0.1, pretty please.
Flags: wanted1.9.0.x+
Comment on attachment 322345 [details] [diff] [review] fix v1 a=shaver, please land on CVS trunk before noon Pacific.
Attachment #322345 -
Flags: approval1.9+
|
|
Assignee | |
Comment 5•16 years ago
|
||
I checked in the patch from the comment 1 to the trunk: http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&branch=HEAD&cvsroot=%2Fcvsroot&date=explicit&mindate=1211997242&maxdate=1211997600&who=igor%25mir2.org
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Updated•16 years ago
|
Flags: in-testsuite-
Flags: in-litmus-
|
||
Updated•16 years ago
|
Flags: wanted1.9.0.x+
You need to log in
before you can comment on or make changes to this bug.
Description
•