The default bug view has changed. See this FAQ.

SM: return without JS_POP_TEMP_ROOT in js_OnUnknownMethod

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: Igor Bukanov, Assigned: Igor Bukanov)

Tracking

Trunk
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
My fix for bug 355258 introduced a regression in js_OnUnknownMethod: the method got early return  after failed js_IsFunctionQName. That would lead to the missing  JS_POP_TEMP_ROOT on out-of-memory.

The static analyzer for the control flow discovered this bug, see bug 432915.
(Assignee)

Comment 1

9 years ago
Created attachment 322345 [details] [diff] [review]
fix v1

The fix added the missing goto.
Assignee: general → igor
Status: NEW → ASSIGNED
Attachment #322345 - Flags: review?(brendan)
Comment on attachment 322345 [details] [diff] [review]
fix v1

Should go into .next -- guess that means into jsinterp.cpp in mozilla-central when it is open.

/be
Attachment #322345 - Flags: review?(brendan) → review+
3.0.1, pretty please.
Flags: wanted1.9.0.x+
Comment on attachment 322345 [details] [diff] [review]
fix v1

a=shaver, please land on CVS trunk before noon Pacific.
Attachment #322345 - Flags: approval1.9+
(Assignee)

Comment 5

9 years ago
I checked in the patch from the comment 1 to the trunk:

http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&branch=HEAD&cvsroot=%2Fcvsroot&date=explicit&mindate=1211997242&maxdate=1211997600&who=igor%25mir2.org
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED

Updated

9 years ago
Flags: in-testsuite-
Flags: in-litmus-
Flags: wanted1.9.0.x+
You need to log in before you can comment on or make changes to this bug.