Last Comment Bug 435546 - SM: return without JS_POP_TEMP_ROOT in js_OnUnknownMethod
: SM: return without JS_POP_TEMP_ROOT in js_OnUnknownMethod
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: Igor Bukanov
:
: Jason Orendorff [:jorendorff]
Mentors:
Depends on:
Blocks: 355258 432915
  Show dependency treegraph
 
Reported: 2008-05-24 01:11 PDT by Igor Bukanov
Modified: 2008-12-17 18:29 PST (History)
4 users (show)
bob: in‑testsuite-
bob: in‑litmus-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix v1 (1.06 KB, patch)
2008-05-24 01:25 PDT, Igor Bukanov
brendan: review+
shaver: approval1.9+
Details | Diff | Splinter Review

Description Igor Bukanov 2008-05-24 01:11:38 PDT
My fix for bug 355258 introduced a regression in js_OnUnknownMethod: the method got early return  after failed js_IsFunctionQName. That would lead to the missing  JS_POP_TEMP_ROOT on out-of-memory.

The static analyzer for the control flow discovered this bug, see bug 432915.
Comment 1 Igor Bukanov 2008-05-24 01:25:14 PDT
Created attachment 322345 [details] [diff] [review]
fix v1

The fix added the missing goto.
Comment 2 Brendan Eich [:brendan] 2008-05-27 15:07:07 PDT
Comment on attachment 322345 [details] [diff] [review]
fix v1

Should go into .next -- guess that means into jsinterp.cpp in mozilla-central when it is open.

/be
Comment 3 Mike Shaver (:shaver -- probably not reading bugmail closely) 2008-05-28 10:23:50 PDT
3.0.1, pretty please.
Comment 4 Mike Shaver (:shaver -- probably not reading bugmail closely) 2008-05-28 10:49:53 PDT
Comment on attachment 322345 [details] [diff] [review]
fix v1

a=shaver, please land on CVS trunk before noon Pacific.

Note You need to log in before you can comment on or make changes to this bug.