Closed Bug 435550 Opened 13 years ago Closed 11 years ago

about: flawed for localization

Categories

(Firefox :: General, defect)

3.0 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3.7a5

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(1 file, 2 obsolete files)

Currently, phrases in about: are cut in three strings: beforeLink, linkTitle and afterLink. While this is not a bad idea, what is one is to have a space "hardcoded" between each of those. Some languages, such as japanese, usually don't use spaces in sentences. It happens about.dtd is not localized in japanese, but if it were, the about: page would look weird.
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Attachment #322348 - Flags: review?
Attachment #322348 - Flags: review? → review?(l10n)
Comment on attachment 322348 [details] [diff] [review]
patch

r-, this needs either a change in entity names or a patch for l10n, l10n is frozen right now, though. Probably both.

We shouldn't really touch this until we have l10n for Firefox 3.1 up for general consumption, which will take a while.
Attachment #322348 - Flags: review?(l10n) → review-
Attached patch patch - v2 (obsolete) — Splinter Review
Attachment #322348 - Attachment is obsolete: true
Attachment #344007 - Flags: review?(l10n)
Comment on attachment 344007 [details] [diff] [review]
patch - v2

I don't see my review comments addressed, r- for the same reasons as before.
Attachment #344007 - Flags: review?(l10n) → review-
Comment on attachment 344007 [details] [diff] [review]
patch - v2

I changed the entity names. Look closer. :)
Attachment #344007 - Flags: review- → review?(l10n)
Oops, sorry.

CCing Adrian and Gandalf, would you have cycles to create a silme script to generate l10n patches corresponding the en-US one? If, we could either publish the script for localizers, or the patches, possibly landing the latter, too.
working on that
Attachment #344007 - Flags: review?(l10n) → review+
Comment on attachment 344007 [details] [diff] [review]
patch - v2

r=me, though I'm not eager to land this right away. I really don't think this is big enough to break string freeze, and for landing on central, this could lead to confusion then.

If you don't mind holding back on it 'til "sometime next year" ;-)
The attached patch doesn't apply anymore.
Keywords: checkin-needed
Attached patch Refreshed patchSplinter Review
Attachment #344007 - Attachment is obsolete: true
Keywords: checkin-needed
Before I check that in (now that I can), is there some prerequisite for l10n or is it just okay to change strings on m-c ?
Keywords: checkin-needed
I guess we should just land this, but make the check-in comment say explicitly that you're moving the whitespace from the xhtml to the DTD, so that people reading that know what they want to do.

Also, could you add a localization note similar to the one that's in the context to this patch?

And once you land, a quick post to mozilla.dev.l10n about that change would be good, for those that don't read the check-in comments.
Thanks, will do when m-c reopens.
http://hg.mozilla.org/mozilla-central/rev/d10d49ee252d
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a5
You need to log in before you can comment on or make changes to this bug.