435550 - about: flawed for localization

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Mike Hommey [:glandium]]

Currently, phrases in about: are cut in three strings: beforeLink, linkTitle and afterLink. While this is not a bad idea, what is one is to have a space "hardcoded" between each of those. Some languages, such as japanese, usually don't use spaces in sentences. It happens about.dtd is not localized in japanese, but if it were, the about: page would look weird.

Comment 1

[Mike Hommey [:glandium]]

Attachment: patch

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 322348 [details] [diff] [review]
patch

r-, this needs either a change in entity names or a patch for l10n, l10n is frozen right now, though. Probably both.

We shouldn't really touch this until we have l10n for Firefox 3.1 up for general consumption, which will take a while.

Comment 3

[Reed Loden [:reed]]

Attachment: patch - v2

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 344007 [details] [diff] [review]
patch - v2

I don't see my review comments addressed, r- for the same reasons as before.

Comment 5

[Reed Loden [:reed]]

Comment on attachment 344007 [details] [diff] [review]
patch - v2

I changed the entity names. Look closer. :)

Comment 6

[Axel Hecht [:Pike]]

Oops, sorry.

CCing Adrian and Gandalf, would you have cycles to create a silme script to generate l10n patches corresponding the en-US one? If, we could either publish the script for localizers, or the patches, possibly landing the latter, too.

Comment 7

[Zibi Braniecki [:zbraniecki][:gandalf]]

working on that

Comment 8

[Axel Hecht [:Pike]]

Comment on attachment 344007 [details] [diff] [review]
patch - v2

r=me, though I'm not eager to land this right away. I really don't think this is big enough to break string freeze, and for landing on central, this could lead to confusion then.

If you don't mind holding back on it 'til "sometime next year" ;-)

Comment 9

[Dão Gottwald [::dao]]

The attached patch doesn't apply anymore.

Comment 10

[Mike Hommey [:glandium]]

Attachment: Refreshed patch

Comment 11

[Mike Hommey [:glandium]]

Before I check that in (now that I can), is there some prerequisite for l10n or is it just okay to change strings on m-c ?

Comment 12

[Axel Hecht [:Pike]]

I guess we should just land this, but make the check-in comment say explicitly that you're moving the whitespace from the xhtml to the DTD, so that people reading that know what they want to do.

Also, could you add a localization note similar to the one that's in the context to this patch?

And once you land, a quick post to mozilla.dev.l10n about that change would be good, for those that don't read the check-in comments.

Comment 13

[Mike Hommey [:glandium]]

Thanks, will do when m-c reopens.

Comment 14

[Mike Hommey [:glandium]]

http://hg.mozilla.org/mozilla-central/rev/d10d49ee252d