435656 - Make nsCxPusher::Push to handle all kinds of nsPIDOMEventTargets

Status: RESOLVED FIXED

(Core :: DOM: Events, defect, P2)

Description

[Olli Pettay [:smaug][[e-mail]]]

Currently nsCxPusher::Push(nsISupports*) is used with DOM Nodes and |window|,
but it should be able handle all kinds of nsPIDOMEventTarget objects, like
XHR (once bug 372964 is fixed).

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: possible patch

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Any chance for a review?

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

wanted1.9.1? because this blocks bug 372964, which blocks wanted1.9.1+ bug 435425.

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 322445 [details] [diff] [review]
possible patch

- In nsCxPusher::Push():

-  if (mScx) {
-    NS_ERROR("Whaaa! No double pushing with nsCxPusher::Push()!");
-
-    return PR_FALSE;
[...]
+  NS_ASSERTION(!mScx, "Whaaa! No double pushing with nsCxPusher::Push()!");

Unless there's a reason not to, I'd still prefer to leave the early return if we ever get here, just in case.

- In nsContentUtils::GetContextForEventHandlers():

+  if (sgo) {
+    NS_IF_ADDREF(*aContext = sgo->GetContext());
+    // Bad, no context from script global object!
+    NS_ENSURE_STATE(*aContext);
+  }
+
+  return NS_OK;

It's possible for us to return here w/o ever having set *aContext to null.

r+sr=jst with that looked into.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch