43575 - Replying to a message with one sender fails to populate To Field

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P3)

Description

[Scott MacGregor]

Note: i believe this problem is different from the earlier problem i field today
with us dropping many of the recipients when replying to a message.


In a build from 9:30 tonight, if i reply to a message, the to field is not being
populated with the sender. I have to enter it by hand.

Comment 1

[laurel]

Happens with today's commercial linux build and mac build, too.

Comment 2

[Jay Patel [:jay]]

Putting on [nsbeta2+] radar for beta2 fix. 

Comment 3

[Suresh]

Also after selecting a AB card in AB window and clicking on 'New Msg' button 
should populate the To field in compose window. 

Comment 4

[Jean-Francois Ducarroz]

*** Bug 43649 has been marked as a duplicate of this bug. ***

Comment 5

[scottputterman]

adding myself to cc

Comment 6

[Jim Roskind]

IMO, not being able to just hit REPLY is a real pain.  Typing email addresses is 
error prone.
I'm nominating for dogfood.  This is too basic to not work.

Comment 7

[Jean-Francois Ducarroz]

David, for some reason, the textfield loose its content either when we pre filed 
the addressing widget or when you scroll the recipients list. Any idea?

Comment 8

[scottputterman]

reassigning to rods and cc'ing ducarroz

Rod, I did a bunch of pulls and backing out and found that when I back out your 
changes to nsGfxTextControlFrame2.cpp r =1.40 and nsGfxTextControlFrame.h 
r=1.20 from 6/22 19:30 that this bug goes away.  If someone has a build, could 
they verify that this is the case and Rod any help you can give on this bug 
which I'm pretty sure will be a dogfood blocker, will be appreciated.

Comment 9

[Phil Peterson]

This bug makes the app really hard to use. I have to retype the recipients :-(
Marking dogfood+

Comment 10

[rods (gone)]

I am trying to take a look at this but mozilla keeps crashing on me. I really 
don't see how my changes are keeping the values from being set. My changes had 
to do with the sizing of the GfxText only. And the sizing of GfxText in 
NavQuirks mode (mostly).

Putterman, what else did you back out in order to back out my changes?

Comment 11

[Jean-Francois Ducarroz]

As soon my build is done, I will back out nsGfxTextControlFrame2.cpp/.h to 
confirm if they are really the culprit.

Comment 12

[Jean-Francois Ducarroz]

*** Bug 43830 has been marked as a duplicate of this bug. ***

Comment 13

[Jean-Francois Ducarroz]

Rods, I took a fresh build from this morning, pull back 
nsGfxTextControlFrame2.cpp to rev 1.39 (cvs update -r "1.39" 
nsGfxTextControlFrame2.cpp)and pull back nsGfxTextControlFrame2.h to rev 1.19 
(cvs update -r "1.19" nsGfxTextControlFrame2.h). Then I had to reply patch 1.41 
into nsGfxTextControlFrame2.cpp in order to make this stuff compile again.

With that, I don't see anymore the problem.

Comment 14

[scottputterman]

Rod I had pulled a tree by date back to 6/22 at 20:58.  This bug existed then.  
Previousy I had pulled a tree by date back to 6/22 at 18:00 and the bug was 
there. So I knew the checkin was during those 3 hours.  Then I started backing 
out files that looked suspicious.  It wasn't until I backed out the changes I 
mentioned before that this bug went away (I put back the other changes I had 
backed out).

Comment 15

[Jean-Francois Ducarroz]

*** Bug 43855 has been marked as a duplicate of this bug. ***

Comment 16

[rods (gone)]

Is anybody else seeing an assert in nsAreadableString when they hit reply on a 
message?

Comment 17

[Jean-Francois Ducarroz]

Rods, the easy and quick way to reproduce this problem is to use mailto url:

in the browser window, just type:
mailto:[e-mail]

You can also start mozilla with the following command line:
mozilla -compose to=[e-mail]

in bopth case, you should get a compose window with a recipient already prefiled 
to [e-mail]

Comment 18

[Jean-Francois Ducarroz]

I am taking back this bug as I have a fix for it (thanks to David Hyatt):

Index: src/nsGfxTextControlFrame2.cpp
===================================================================
RCS file: /cvsroot/mozilla/layout/html/forms/src/nsGfxTextControlFrame2.cpp,v
retrieving revision 1.43
diff -r1.43 nsGfxTextControlFrame2.cpp
1353c1353
<   if (eReflowReason_Initial == aReflowState->reason)
---
>   if (mState & NS_FRAME_FIRST_REFLOW)

Comment 19

[Jean-Francois Ducarroz]

Fix checked in

Comment 20

[laurel]

OK using jun27 commercial build, linux rh6.0, NT 4.0 and mac OS 9.0

OK for reply to a message, prefills OK.
OK for new message to newsgroup, prefills OK.
OK for new message from AB window, card selected, prefills OK.