435798 - Two consecutive window.print() calls crash Firefox [@ nsPrintEngine::DoCommonPrint]

Status: VERIFIED WORKSFORME

(Core :: Printing: Output, defect)

Description

[Michiel Trimpe]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; nl; rv:1.8.1.14) Gecko/20080404 Firefox/2.0.0.14
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; nl; rv:1.8.1.14) Gecko/20080404 Firefox/2.0.0.14

When window.print() is called two times in a row (which happened in our case when jQuery attached window.print() to the .print class and in the page both the <li> and the <span> within had this class) Firefox crashes. 
Bug reproduced on Mac OS X and Windows XP.

Reproducible: Always

Steps to Reproduce:
1. Open FireBug console
2. Write 'window.print(); window.print()'
3. Execute and crash
Actual Results:  
Firefox 'shut down unexpectedly'

Expected Results:  
Show the print dialog twice and let the user print twice. Showing it only once probably isn't logical but is what's appropriate in most situations.

Comment 1

[Mats Palmgren (inactive)]

Attachment: Testcase

This crashes Firefox 3.0 RC1 on MacOSX 10.5.2 for me.

Comment 2

[Mats Palmgren (inactive)]

Crash data: bp-20f26407-2cde-11dd-9ea7-001a4bd46e84

nsPrintEngine::DoCommonPrint	 mozilla/layout/printing/nsPrintEngine.cpp:601
nsPrintEngine::CommonPrint	mozilla/layout/printing/nsPrintEngine.cpp:418
nsPrintEngine::Print	mozilla/layout/printing/nsPrintEngine.cpp:724
DocumentViewerImpl::Print	mozilla/layout/base/nsDocumentViewer.cpp:3487
DocumentViewerImpl::LoadComplete	mozilla/layout/base/nsDocumentViewer.cpp:1027
nsDocShell::EndPageLoad	mozilla/docshell/base/nsDocShell.cpp:5096
nsWebShell::EndPageLoad	mozilla/docshell/base/nsWebShell.cpp:1013
nsDocShell::OnStateChange	mozilla/docshell/base/nsDocShell.cpp:5001
nsDocLoader::FireOnStateChange	mozilla/uriloader/base/nsDocLoader.cpp:1235
nsDocLoader::doStopDocumentLoad	mozilla/uriloader/base/nsDocLoader.cpp:858
nsDocLoader::DocLoaderIsEmpty	mozilla/uriloader/base/nsDocLoader.cpp:763
nsDocLoader::OnStopRequest	mozilla/uriloader/base/nsDocLoader.cpp:679
nsLoadGroup::RemoveRequest	mozilla/netwerk/base/src/nsLoadGroup.cpp:688
nsDocument::DoUnblockOnload	mozilla/content/base/src/nsDOMSerializer.cpp:5740
nsDocument::DispatchContentLoadedEvents	mozilla/content/base/src/nsDOMSerializer.cpp:2854
nsRunnableMethod<nsDocument>::Run	mozilla/gfx/cairo/libpixman/src/pixman-access-accessors.c:260
nsThread::ProcessNextEvent	mozilla/xpcom/threads/nsThread.cpp:510
NS_ProcessPendingEvents_P	nsThreadUtils.cpp:180
nsBaseAppShell::NativeEventCallback	mozilla/widget/src/xpwidgets/nsBaseAppShell.cpp:121
nsAppShell::ProcessGeckoEvents	mozilla/widget/src/cocoa/nsAppShell.mm:302
CFRunLoopRunSpecific	
CFRunLoopRunInMode	
RunCurrentEventLoopInMode	
ReceiveNextEventCommon	
BlockUntilNextEventMatchingListInMode	
_DPSNextEvent	
-[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:]	
-[NSApplication run]	
nsAppShell::Run	mozilla/widget/src/cocoa/nsAppShell.mm:591 
...

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

WFM on trunk (linux and OSX).
Please reopen if you can still reproduce.

Comment 4

[Mats Palmgren (inactive)]

WFM too, trunk and 3.0.7, on Linux and MacOSX.