435817 - Page cached with wrong l10n

Status: RESOLVED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Matthew Middleton (:zzxc)]

The Live Chat page (see the url) is currently cached with zh-TW links and user interface.  (If people browse the site using links here, they end up on zh-TW pages)

Comment 1

[Nelson Ko [:nkoth]]

Additionally,

http://support.mozilla.com/en-US/kb/Managing%20profiles is in zh-TW
http://support.mozilla.com/en-US/kb/When+will+Firefox+3+be+released is in ca
http://support.mozilla.com/en-US/kb/Running+Firefox+on+mobile+devices is in ca

I can't for the life of me reproduce this in support-stage.mozilla.org. lorchard, could this be memcache related?

Comment 2

[Les Orchard [:lorchard]]

Attachment: Uncommenting locale as part of page output cache keys

Not sure why, but I must've commented out the locale part of the cache key generation.

Though I can't personally reproduce this bug, this change is the only thing I can think of that might be causing it.

Comment 3

[Nelson Ko [:nkoth]]

Comment on attachment 322598 [details] [diff] [review]
Uncommenting locale as part of page output cache keys

looks like worth a try. What do you think Laura?

Comment 4

[Laura Thomson :laura]

I wish we could repro, but this patch WFM.

Comment 5

[Les Orchard [:lorchard]]

I've gone ahead and checked this in and tagged it:

https://svn.mozilla.org/projects/sumo/tags/1.0/20080526_r13867/

Comment 6

[Chris Ilias [:cilias]]

FWIW, you need to be logged out to reproduce it.

Comment 7

[Laura Thomson :laura]

lorchard, did you request a push for this?

Comment 8

[Les Orchard [:lorchard]]

I hadn't requested a push, but I have now.

Comment 9

[Les Orchard [:lorchard]]

For what it's worth, I was eventually able to reproduce this bug on my dev machine with the following two pages:

http://support.mozilla.com/en-US/kb/Installing+Firefox+on+Mac
http://support.mozilla.com/zh-TW/kb/Installing+Firefox+on+Mac

Visiting the zh-TW locale repeatedly eventually gave the en-US locale incorrectly cached links surrounding the content.

Comment 10

[Les Orchard [:lorchard]]

Attachment: Include locale in output cache key, invalidate all caches for a page on approval / rollback

As it turns out, my previous patch appears only to have fixed half of the problem.  

I assumed the locale was directly tied to the page content, when in reality the same page content can be displayed in multiple locale contexts.  Thus, if someone viewed an English page in a non-English context, the English context would display the nav links and etc for the non-English context as well.

So, the previous patch partially fixed that.  But, it also partially broke approval and rollback, in that the changes would appear only for the locale used by the user performing the action.

This reworked patch caches page output by locale, but invalidates all locale-wise caches for a page when approval or rollback occurs.  

This is done by maintaining a timestamp for caches by locale and page name, as well as a timestamp for the page name alone when approval/rollback occurs.  When the page is visited, the output cache timestamp is compared with the page name timestamp.  If the page name time is newer than the output time, the output cache is discarded.  Thus, caches for all combination of locale and page name will be invalidated after approval/rollback.

Comment 11

[Les Orchard [:lorchard]]

Hopefully with the latest push, this should be fixed.

https://svn.mozilla.org/projects/sumo/tags/1.0/20080530_r14170/