Ensure byte length limits of l10n messages, notably in pipnss.properties

NEW
Unassigned

Status

11 years ago
a year ago

People

(Reporter: Pike, Unassigned)

Tracking

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

11 years ago
Looking at bug 317630 and bug 435789, we should probably have a better grip on those length limits. Before moving this into localization or testing, are only the commented entries in pipnss.properties affected or are there more?

It'd be good to have both a source and a runtime check.
Flags: in-testsuite?
Flags: in-litmus?
(Reporter)

Comment 1

11 years ago
One way to reproduce a cut off name is to 

1. set Firefox to have a master password 
2. Go to an url that requires login
3. the popup dialog appears with a shortened string

according to Damjan on #l10n.
(Reporter)

Comment 2

11 years ago
Kai, can you help out here with a comment?
The commented strings in pipnss.properties are all I'm aware of.

I'm not sure what "source" check you have in mind. Something in the tools that localizers use?

Regarding runtime check, we could check the loaded strings just before calling PK11_ConfigurePKCS11, but what do you propose to do?
(Reporter)

Comment 4

11 years ago
Created attachment 324962 [details]
ad-hoc test

This is an ad-hoc test, and sadly, we're hitting this all over.

I'll file individual bugs per locale.

af:
        Fips140TokenDescription:        2 bytes
be:
        Fips140TokenDescription:        1 bytes
ca:
        InternalToken:  5 bytes
        PrivateTokenDescription:        5 bytes
        LibraryDescription:     3 bytes
        Fips140TokenDescription:        12 bytes
cs:
        LibraryDescription:     1 bytes
es-AR:
        TokenDescription:       3 bytes
        InternalToken:  5 bytes
        PrivateTokenDescription:        5 bytes
        LibraryDescription:     8 bytes
        Fips140TokenDescription:        12 bytes
eu:
        LibraryDescription:     1 bytes
        Fips140TokenDescription:        1 bytes
fr:
        LibraryDescription:     5 bytes
        Fips140TokenDescription:        8 bytes
fy-NL:
        Fips140TokenDescription:        4 bytes
ga-IE:
        TokenDescription:       1 bytes
        LibraryDescription:     6 bytes
hu:
        Fips140SlotDescription: 2 bytes
        Fips140TokenDescription:        4 bytes
hy-AM:
        LibraryDescription:     7 bytes
id:
        InternalToken:  2 bytes
        PrivateTokenDescription:        2 bytes
        Fips140TokenDescription:        9 bytes
it:
        LibraryDescription:     1 bytes
        Fips140TokenDescription:        8 bytes
kn:
        TokenDescription:       1 bytes
ku:
        Fips140SlotDescription: 2 bytes
        LibraryDescription:     2 bytes
        Fips140TokenDescription:        7 bytes
lt:
        Fips140TokenDescription:        2 bytes
mn:
        LibraryDescription:     6 bytes
        Fips140TokenDescription:        7 bytes
nb-NO:
        Fips140TokenDescription:        2 bytes
nl:
        Fips140TokenDescription:        4 bytes
nn-NO:
        Fips140TokenDescription:        16 bytes
pt-PT:
        InternalToken:  4 bytes
        PrivateTokenDescription:        4 bytes
        Fips140TokenDescription:        11 bytes
ro:
        LibraryDescription:     2 bytes
        Fips140TokenDescription:        8 bytes
rw:
        InternalToken:  6 bytes
        PrivateTokenDescription:        6 bytes
        LibraryDescription:     1 bytes
sk:
        Fips140TokenDescription:        2 bytes
sq:
        InternalToken:  1 bytes
        PrivateTokenDescription:        1 bytes
        Fips140TokenDescription:        8 bytes
sr:
        Fips140SlotDescription: 2 bytes
        Fips140TokenDescription:        10 bytes
uk:
        InternalToken:  9 bytes
        Fips140TokenDescription:        16 bytes
zu:
        TokenDescription:       2 bytes
        InternalToken:  4 bytes
        PrivateTokenDescription:        4 bytes
        LibraryDescription:     15 bytes
Assignee: kaie → l10n
Status: NEW → ASSIGNED
(Reporter)

Comment 5

11 years ago
Over to l10n.
Assignee: l10n → nobody
Status: ASSIGNED → NEW
Component: Security: PSM → Other
Flags: in-testsuite?
Flags: in-litmus?
Product: Core → Mozilla Localizations
QA Contact: psm
(Reporter)

Updated

11 years ago
Assignee: nobody → l10n
(Reporter)

Updated

11 years ago
Flags: in-testsuite?
(Reporter)

Updated

8 years ago
Assignee: l10n → nobody
Component: Other → Infrastructure
QA Contact: infrastructure
(Reporter)

Updated

8 years ago
Duplicate of this bug: 685264
(Reporter)

Updated

8 years ago
Summary: Ensure byte length limits of l10n messages → Ensure byte length limits of l10n messages, notably in pipnss.properties
(Reporter)

Comment 7

7 years ago
arky, you asked about a test, here's a python file that does that.
Tentatively moving to compare-locales, since I think there's value in this kind of checks.
We have fixed a good amount of errors in the past week, but we still have 145 spread across 45 locales.

Bug 320231 added machine readable comments to that string, in case someone wants to give it a try.
Component: Infrastructure → compare-locales
Flags: in-testsuite?
Product: Mozilla Localizations → Localization Infrastructure and Tools
You need to log in before you can comment on or make changes to this bug.