436046 - display != none should not apply to input[type=hidden]

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Alex Hall]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.8.1.14) Gecko/20080404 Firefox/2.0.0.14
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.8.1.14) Gecko/20080404 Firefox/2.0.0.14

When applying a border to all inputs on a web page, if there are any hidden inputs present this border can be seen on the hidden inputs too.

Reproducible: Always

Steps to Reproduce:
1. Create a form with hidden inputs
2. Style all inputs to have a border of some kind
3. View page
Actual Results:  
The border of the hidden input was visible

Expected Results:  
Hidden inputs should not show borders

Comment 1

[Alex Hall]

Attachment: Hidden Input Showing A Border Styled In CSS

This attachment shows the bug in action. The hidden input clearly has the border set.

Comment 3

[Daniel.S]

Attachment: testcase

Comment 4

[Daniel.S]

Attachment: Workaround in forms.css

If we simply change the rule to display: none !important; most, if not all cases on the web should be fixed.

IE, Safari and Opera do not allow styling of hidden input fields in any case.

Comment 6

[Boris Zbarsky [:bzbarsky]]

It's worth looking into the CVS history here; I seem to recall not being able to switch that rule to !important for some reason...

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 375354 [details] [diff] [review]
Workaround in forms.css

bz is probably a better reviewer for this than me

Comment 8

[Daniel.S]

(In reply to comment #6)
> It's worth looking into the CVS history here; I seem to recall not being able
> to switch that rule to !important for some reason...

In bug 109847 comment #17 you had the argument of easy debugging to not !important.

Then, in bug 166438 comment #6 you said
> I'd have no qualms about adding that !important if we want to... but if this is
> the only site having this issue, I would rather evang them.

The issue seems to be slightly more common, so what do you think now?

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 375354 [details] [diff] [review]
Workaround in forms.css

OK, let's do this.

<sigh>.  I hate the web.

Comment 10

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/mozilla-central/rev/c37853610d13

Want to add a test?

Comment 11

[Jesse Ruderman]

I added the testcase as an equals-blank reftest:

http://hg.mozilla.org/mozilla-central/rev/ed294d9c6bfd