436104 - Potentially erratic searching through address books

Status: RESOLVED FIXED

(MailNews Core :: Search, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

On bug 426317, Kent picked up the following:

While reviewing the address book search setup as part of preparing unit tests
for bug 187768, I saw some code I did not understand which I traced to this
patch.

Previously, in nsMsgSearchTerm::InitializeAddressBook there was this code:

    if (strcmp(dirURI.get(), m_value.string))
      mDirectory = nsnull; // clear out the directory....we are no longer
pointing to the right one


which has now been replaced by:

    if (uri.Equals(m_value.string))
      // clear out the directory....we are no longer pointing to the right one
      mDirectory = nsnull;

But the logic is backwards. strcmp returns 0 (false) when the string are equal.
So the new code should be:

    if (!uri.Equals(m_value.string))


I'm not quite sure of the effects, but I bet it would mess up some of our searching/filtering where we match in the address book. As this was in TB 3.0a1 I'm cc'ing QA people so they know about this potential problem.

Comment 1

[Mark Banner (:standard8)]

Patch checked in, fixed.