436162 - ActionMonkey: Make it work on Intel64

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

ActionMonkey must build and run on Intel64 before it lands.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Preliminary look:

I got this to build on x86_64 but four extra tests failed versus my i386 build.  I'll look into them in more depth soon.  The four were all eating up insane amounts of CPU and memory, and one in particular I had to kill after waiting about an hour.

I didn't get any compile-time errors, the only thing I had to do was fix some of the Makefiles and Python scripts.

Comment 2

[Bob Clary [:bc] (inactive)]

David, I assume 

/work/mozilla/builds/1.9.1-actionmonkey/mozilla/js/tamarin/./codegen/manifest.mk:55: *** Unrecognized target CPU..  Stop. 

during firefox build and bug 436263

jsapi.cpp: In function ‘jsval* JS_PushArgumentsVA(JSContext*, void**, const char*, __va_list_tag*)’:
jsapi.cpp:381: error: cannot convert ‘__va_list_tag**’ to ‘__va_list_tag (*)[1]’ for argument ‘5’ to ‘JSBool TryArgumentFormatter(JSContext*, const char**, JSBool, jsval**, __va_list_tag (*)[1])’ 

during shell build are known for the actionmonkey repo?

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: Fixes building against spidermonkey, building on gcc-4.2

Comment 4

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: Fixes ActionMonkey build issues on AMD64

Most of this patch is mirrored from bug 436263

Comment 5

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: Fixes Tamarin build issues on AMD64

To build 64-bit on Darwin, make -f Makefile.ref OS_ARCH=Darwin64 (doing so bumps the OS requirement to 10.5)

Comment 6

[Bob Clary [:bc] (inactive)]

Can we go ahead and get these patches checked in to actionmonkey and any other repositories where they may be needed?

Comment 7

[Jason Orendorff [:jorendorff]]

Mass-WONTFIXing ActionMonkey bugs.