Closed Bug 436175 Opened 12 years ago Closed 11 years ago

chevron in bookmarks toolbar is reversed in RTL locales

Categories

(Firefox :: Theme, defect)

3.5 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 3.6a1

People

(Reporter: tsahi_75, Assigned: ehsan)

Details

(Keywords: fixed1.9.1, rtl)

Attachments

(2 files)

when the UI is in Right to Left mode, in RTL locales (Hebrew, and most likely Arabic and Persian too though i didn't check), the chevron icon at the end (left) of the bookmarks toolbar points to the right instead of to the left.

the chevron is displayed if you have too many bookmarks to fit to your screen/window.
I can reproduce on GTK. Yehuda, can you reproduce on OSX theme?
Keywords: rtl
OS: Windows XP → All
(In reply to comment #1)
> Yehuda, can you reproduce on OSX theme?
> 
Yes, it is the same issue with OSX theme
Attached patch Patch (v1)Splinter Review
winstripe and gnomestripe already have the RTL version of chevron.png, and the necessary CSS rules.
Assignee: nobody → ehsan.akhgari
Status: NEW → ASSIGNED
Attachment #356961 - Flags: review?(dao)
Attachment #356961 - Flags: review?(dao) → review+
http://hg.mozilla.org/mozilla-central/rev/4b890ad7f2c1
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-litmus?
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.2a1
Version: 3.0 Branch → 3.1 Branch
Comment on attachment 356961 [details] [diff] [review]
Patch (v1)

Small theme change to make Firefox a bit more RTL-friendly.  Requesting approval for 1.9.1.
Attachment #356961 - Flags: approval1.9.1?
Comment on attachment 356961 [details] [diff] [review]
Patch (v1)

a191=beltzner
Attachment #356961 - Flags: approval1.9.1? → approval1.9.1+
Flags: in-litmus?
You need to log in before you can comment on or make changes to this bug.