436272 - Task with '% complete' greater than 100% -> '% complete' box is empty

Status: RESOLVED FIXED

(Calendar :: Tasks, defect)

Description

[Andreas Treumann]

STEPS TO REPRODUCE:
===================

- create a new task
- select the 'in progress' status
- insert a '% complete' value with more than 100%
- save and close the task
- open the edit dialog of this task and check '% complete'

RESULT:
=======

- the box is empty

EXPECTED RESULT:
================

- the value should be automatically set to 100%

REPRODUCIBLE:
=============

- always

Comment 1

[Stefan Sitter [:ssitter]]

This seems to be "just" an issue with the event dialog.

If I create a task, set the '% complete' value to 100% or greater and save it the value is already limited to 100%. This can be verified by looking at the task tooltip or by exporting the task to the iCalendar format.

Happens only if the status is set to 'In Process' and '% complete' >= 100% in the dialog. If the status is set to 'Completed' or the '% complete' is set to 100% via task list context menu it works.

Comment 2

[Robert Brand]

Still valid with recent Lightning 1.1a1pre nightly.

First a value greater than 100 is stored as 100%. When opening the event dialog, it seems that an if-else-block in function updateToDoStatus [1] is responsible for the described behaviour:
The status is not "completed"; the percent complete value is read and checked, and since it is not unequal to 100, it is told to be set to "".
Why is the dialog told to do this?


[1] http://mxr.mozilla.org/comm-central/source/calendar/base/content/dialogs/calendar-event-dialog.js#2216

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

This code goes way back to mozilla1.8, feel free to change it any way you like to fix this bug.

Comment 4

[Robert Brand]

Attachment: patch_v1

Maybe this is all we need then?
Show the percent complete value we have, no need to hide 100%...

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 515518 [details] [diff] [review]
patch_v1

Sounds reasonable to me, r=philipp

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/e066581ac82d>

-> FIXED

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Backported to comm-1.9.2 <http://hg.mozilla.org/releases/comm-1.9.2/rev/d0217f549619>