436367 - TT: File.fileToByteArray does not set the length of the returning ByteArray

Status: VERIFIED FIXED

(Tamarin Graveyard :: Tracing Virtual Machine, defect)

Description

[Dan Schaffer]

File.fileToByteArray should set length to ByteArray as the number of bytes read.  Many ByteArray function fail since they check if the pointer is past the length

this simple code e.g. shows the problem:
test.txt:
12345

bug.as:
import avmplus.*
var ba:ByteArray=File.fileToByteArray("test.txt",false);
print("bytearray.length should be 5 is 0");
print("bytearray.length="+ba.length);
// workaround manually set length
//ba.length=5;
print("ba[0-5]="+ba[0]+" "+ba[1]+" "+ba[2]+" "+ba[3]+" "+ba[4]);


actual: undefined undefined undefined undefined 
expected: 49 50 51 52 53

Comment 1

[Erik Tierney]

Attachment: Set length of bytearray after creating from file.

Comment 2

[Erik Tierney]

Pushed in changeset http://hg.mozilla.org/tamarin-tracing/index.cgi/rev/b5a18ce0a6d3

Comment 3

[Dan Schaffer]

Attachment: add testcase for File.fileToByteArray setting length correctly

Comment 4

[Dan Schaffer]

pushed new tests in changeset 2732:0a9e319cd180, closing as verified fixed.