When editors are reviewing add-ons, there may be some "back and forth" conversations with the author. Since there is no explicit "I'm dealing with this add-on" or "taken" flag set on an add-on review, editors' work might get mid-air collision'ed (in Bugzilla terminology). We need a "taken" or "reserved" flag so that editors can indicate to other editors that a particular add-on is being worked on.
Agreed, gets my vote.
This has been brought up multiple times. We should try to implement it soon.
I see two possible implementations here: 1) "Watch" When an editor is looking at a review page, an AJAX request is sent at regular intervals, telling AMO that the editor is still watching it. We show in the review list and the review page that "X is looking at this review". Multiple editors would be allowed to watch the same review, but they would also be discouraged to perform a review on an add-on somebody else is watching. 2) "Reserve" We add a link or button to review pages where editors can reserve a review for an hour or so. Nobody can perform a review on an add-on reserved by somebody else, and only an admin can override the reservation (the link would turn into something else like "Unreserve" for admins). I think #1 is more practical, and maybe easier to implement.
Option 1 sounds good. Let's aim this for 5.13
"Multiple editors would be allowed to watch the same review, but they would also be discouraged to perform a review on an add-on somebody else is watching." We'll need to know who is watching first, otherwise everyone will think they are locked out.
We're aiming for option 1 still, although "watching" sounds long term - let's just say they are looking at the page.
https://github.com/jbalogh/zamboni/commit/97da9 This will probably need some tweaks once we see how it's used in the wild. A few random thoughts: - We might want a "The status of this review has changed since you loaded this page" indicator; I think that's more important than who's viewing the page. (If you want this, file a bug.) - I only show the person who currently has the "lock" on the page, since showing everyone would have really complicated the code for what would be (in my opinion) an edge case that doesn't add much benefit. If having a list of everyone on the page is vital, feel free to file a bug. - We can play with the wording and styling. You can file a bug, or just comment here and I can change it. - I had a patch that showed an icon on the review log page, but it was freezing the page up so I didn't land it yet. I'm going to optimize that, and it'll land today or I'll file a bug and land it next week.
Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...