Allow editors to mark an add-on in the review queue as "taken"

RESOLVED FIXED in 6.0.8

Status

addons.mozilla.org Graveyard
Admin/Editor Tools
P3
normal
RESOLVED FIXED
10 years ago
2 years ago

People

(Reporter: baz, Assigned: gkoberger)

Tracking

unspecified
6.0.8

Details

(Whiteboard: [ReviewTeam])

(Reporter)

Description

10 years ago
When editors are reviewing add-ons, there may be some "back and forth" conversations with the author. Since there is no explicit "I'm dealing with this add-on" or "taken" flag set on an add-on review, editors' work might get mid-air collision'ed (in Bugzilla terminology). We need a "taken" or "reserved" flag so that editors can indicate to other editors that a particular add-on is being worked on.

Comment 1

10 years ago
Agreed, gets my vote.
Severity: normal → enhancement
Priority: -- → P5
Target Milestone: --- → Future
This has been brought up multiple times. We should try to implement it soon.
Assignee: nobody → jorge
Severity: enhancement → normal
Status: NEW → ASSIGNED
Priority: P5 → P3
Whiteboard: [required amo-editors]
Target Milestone: Future → 5.12
Version: 3.2 → unspecified
I see two possible implementations here:

1) "Watch"
When an editor is looking at a review page, an AJAX request is sent at regular intervals, telling AMO that the editor is still watching it. We show in the review list and the review page that "X is looking at this review".
Multiple editors would be allowed to watch the same review, but they would also be discouraged to perform a review on an add-on somebody else is watching.

2) "Reserve"
We add a link or button to review pages where editors can reserve a review for an hour or so. Nobody can perform a review on an add-on reserved by somebody else, and only an admin can override the reservation (the link would turn into something else like "Unreserve" for admins).

I think #1 is more practical, and maybe easier to implement.
Assignee: jorge → nobody
Status: ASSIGNED → NEW
Option 1 sounds good.  Let's aim this for 5.13
Target Milestone: 5.12 → 5.13

Comment 5

7 years ago
"Multiple editors would be allowed to watch the same review, but they would also
be discouraged to perform a review on an add-on somebody else is watching."

We'll need to know who is watching first, otherwise everyone will think they are locked out.
Target Milestone: 5.14 → ---
Assignee: nobody → gkoberger
Target Milestone: --- → Q2 2011
We're aiming for option 1 still, although "watching" sounds long term - let's just say they are looking at the page.
Target Milestone: Q2 2011 → 6.0.8
(Assignee)

Comment 7

7 years ago
https://github.com/jbalogh/zamboni/commit/97da9

This will probably need some tweaks once we see how it's used in the wild.

A few random thoughts:
- We might want a "The status of this review has changed since you loaded this page" indicator; I think that's more important than who's viewing the page.  (If you want this, file a bug.)
- I only show the person who currently has the "lock" on the page, since showing everyone would have really complicated the code for what would be (in my opinion) an edge case that doesn't add much benefit.  If having a list of everyone on the page is vital, feel free to file a bug.
- We can play with the wording and styling.  You can file a bug, or just comment here and I can change it.
- I had a patch that showed an icon on the review log page, but it was freezing the page up so I didn't land it yet.  I'm going to optimize that, and it'll land today or I'll file a bug and land it next week.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...
Whiteboard: [required amo-editors] → [ReviewTeam]
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.