Deleting a single instance of a recurring event fails

VERIFIED FIXED in 0.9

Status

Calendar
Provider: WCAP
VERIFIED FIXED
10 years ago
10 years ago

People

(Reporter: Max Spicer, Assigned: dbo)

Tracking

({regression})

Lightning 0.8
regression
Bug Flags:
wanted-calendar0.9 +

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

10 years ago
I've noticed recently that if I delete one occurrence of a repeating event the occurrence disappears in Lightning but is still on my calendar server.  Lightning consistently treats the event as deleted - it isn't shown and doesn't reappear after a reload calendar or restart.  However, the event continues to show up in the web interface and calendar server sends out event reminders for it.  This has caused quite some confusion, as you can probably imagine.

To reproduce:

- Create a repeating event in Lightning.
- Delete the first instance and select the "this one only" option
- Verify that the event no longer appears in Lightning
- Visit calendar server's web interface - the event is still shown

It doesn't matter which occurrence of a repeating event you delete.

This occurs with Lightning 0.8 and also with 0.9pre build 2008052918.  Calendar server is version 6.2 at patch level 116577-42.
(Assignee)

Comment 1

10 years ago
This is definitely a CS server bug and has been reported already. Even though, a fix is AFAIK not in sight we need a solution for this.
Flags: wanted-calendar0.9+
OS: Linux → All
Hardware: PC → All
(Assignee)

Comment 2

10 years ago
Created attachment 323079 [details] [diff] [review]
fix - v1

This is a workaround for the problem. CS cannot cope with the passed &exdates. It saves them (thus we have no problem within Lightning/Sunbird), but it does not update its internal cache holding the expanded occurrences, thus the Web-UI still shows them.
This patch decouples the modifyItem step into two steps:
1. Modify the master item, leaving out the EXDATEs using store_xyz.wcap.
2. Delete any new EXDATEd occurrences using delete_xyz.wcap.

The WCAP code is highly sensible to changes in this area, and I expect regressions, thus even though this may got reviewed, we should run the WCAP test cases.
Assignee: nobody → daniel.boelzle
Status: NEW → ASSIGNED
Attachment #323079 - Flags: review?(philipp)
Comment on attachment 323079 [details] [diff] [review]
fix - v1

r=philipp
Attachment #323079 - Flags: review?(philipp) → review+
(Assignee)

Comment 4

10 years ago
Checked in on HEAD and MOZILLA_1_8_BRANCH => FIXED.

Setting qawanted to request further testing of the patch and find out if anything is regressed by it.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: qawanted
Resolution: --- → FIXED
Target Milestone: --- → 0.9
(Reporter)

Comment 5

10 years ago
Confirming fixed in Lightning 0.9pre 2008060118.  Thanks for the speedy work!
(Assignee)

Comment 6

10 years ago
Created attachment 323351 [details] [diff] [review]
invalidate cache
Attachment #323351 - Flags: review?(philipp)
(Assignee)

Updated

10 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #323351 - Flags: review?(philipp) → review+
(Assignee)

Comment 7

10 years ago
Checked in additional invalidate of cache => FIXED again.
Status: REOPENED → RESOLVED
Last Resolved: 10 years ago10 years ago
Resolution: --- → FIXED

Comment 8

10 years ago
Checked again with lightning build 2008060218, invalidate cache is also fixed -> VERIFIED
Status: RESOLVED → VERIFIED
(Assignee)

Comment 9

10 years ago
fix has regressed creating all-day exceptions/overridden items
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 10

10 years ago
Created attachment 324668 [details] [diff] [review]
fixing all-day overridden items
Attachment #324668 - Flags: review?(philipp)
Comment on attachment 324668 [details] [diff] [review]
fixing all-day overridden items

r=philipp
Attachment #324668 - Flags: review?(philipp) → review+
(Assignee)

Comment 12

10 years ago
Checked in on HEAD and MOZILLA_1_8_BRANCH => FIXED again.
Status: REOPENED → RESOLVED
Last Resolved: 10 years ago10 years ago
Resolution: --- → FIXED
(Assignee)

Comment 13

10 years ago
I am going mad -- the recent fix has regressed Calendar Express again, i.e. events created by Calendar Express cannot be overridden by Lightning...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 14

10 years ago
Created attachment 324763 [details] [diff] [review]
backing out changes

I've been confused by old all-day items which could not be modified any longer (I don't know why, maybe the server's databases are corrupt). Backing out the essential changes works again -- creating/modifying all-day recurring all-day items in Calendar Express and Lightning + cross-usage.
Attachment #324668 - Attachment is obsolete: true
Attachment #324763 - Flags: review?(philipp)
Attachment #324763 - Flags: review?(philipp) → review+
(Assignee)

Comment 15

10 years ago
Checked in on HEAD and MOZILLA_1_8_BRANCH => FIXED again.
Status: REOPENED → RESOLVED
Last Resolved: 10 years ago10 years ago
Resolution: --- → FIXED

Comment 16

10 years ago
I checked this issue in lightning 2008061918, but this bug isn't fixed.

STR:

- delete a single occurrence of an WCAP recurring event
- calendar view looks okay
- reload the view
- event is back
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Updated

10 years ago
Keywords: regression
(Assignee)

Comment 17

10 years ago
depends on regression fix for bug 391495 => FIXED again.
Status: REOPENED → RESOLVED
Last Resolved: 10 years ago10 years ago
Depends on: 391495
Resolution: --- → FIXED

Comment 18

10 years ago
checked in lightning build 2008062503 -> VERIFIED
Status: RESOLVED → VERIFIED
Keywords: qawanted
You need to log in before you can comment on or make changes to this bug.