Closed Bug 436481 Opened 16 years ago Closed 16 years ago

JS error 'cal has no properties' in composite calendar

Categories

(Calendar :: Internal Components, defect)

defect
Not set
trivial

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: Fallen, Assigned: Fallen)

Details

Attachments

(1 file)

Attached patch Fix v1 β€” β€” Splinter Review
      No description provided.
Attachment #323047 - Flags: review?(daniel.boelzle)
Comment on attachment 323047 [details] [diff] [review]
Fix v1

>+        if (cal &&
>+            (this.mDefaultCalendar && this.mDefaultCalendar.id == cal.id) ||
>+            cal.getProperty("disabled")) {
>             return;

please spend some extra braces:

        if (cal &&
            ((this.mDefaultCalendar && this.mDefaultCalendar.id == cal.id) ||
             cal.getProperty("disabled"))) {

r=dbo
Attachment #323047 - Flags: review?(daniel.boelzle) → review+
Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.9
Checked in lightning 2008060118 and sunbird 20080601 -> VERIFIED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: