Closed Bug 436502 Opened 12 years ago Closed 12 years ago

instantApply="tue" in extensions/metrics/content/prefs.xul

Categories

(Toolkit Graveyard :: Data Collection/Metrics, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9

People

(Reporter: stefanh, Assigned: stefanh)

Details

Attachments

(1 file)

I just noticed this while MXR:ing "instantApply". Exists on 1.9.0 too, of course. Obviously, it should be "true". That said, I have no idea if you want the pref to be instantApply or if it works fine as it is.
Attached patch fix spell errorSplinter Review
I don't know who should look at this. I also don't know if it's needed since the instantApply is also set globally...
Comment on attachment 323070 [details] [diff] [review]
fix spell error

patch looks good
Attachment #323070 - Flags: review+
Checking in extensions/metrics/content/prefs.xul;
/cvsroot/mozilla/extensions/metrics/content/prefs.xul,v  <--  prefs.xul
new revision: 1.4; previous revision: 1.3
done
Assignee: nobody → stefanh
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9
I've noticed that this was never merged into the mozilla-central-repo. Was the non-merge intentional?
Do you mean using Mercurial?
(In reply to comment #5)
> Do you mean using Mercurial?
> 
Yeah, I just landed it on 1.9.0 (cvs). It appears that the last merge to hg was made before I landed the patch.
(I assumed it was merged, but it wasn't)
I can land it in the mozilla-central repo, but it will take some time until I have a Mercurial setup (possibly July).
Fixed in mozilla-central with 16277:7b6e94c65c09
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.