43661 - open attachment for certain content types brings up save as dialog not open dialog

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect, P3)

Description

[Scott MacGregor]

I just noticed this problem this morning. For attachments with particular
content types, we don't open them correctly.


This is because the helper app code trys to figure out the file extension for
the url we are trying to open. It first looks to see if the user told us what
the extension is for this content type. Then it looks up in the netscape windows
registry to see if we have a content to file extension mapping. If that still
fails, then we try to get the extension from the URL.

This file extension is then used to again look up in the windows registry to
find the helper app associated with that extension type.

Comment 1

[Scott MacGregor]

I didn't finish my thoughts.

The problem I'm seeing is for open attachmens, if we can't find a content type
to file extension maping in the registry then the helper app code trys to find
it from the url.

For open attachments, this is just an imap or mailbox url. These urls don't
contain the file name of the temp file. So we can't guess at a file extension.


This causes us to fail opening attachments for some content types like:
application/ms-word  (end in .doc)
application/ms-excel (end in .xls)

Nominating for beta2. The fix is to make sure we can get the file extension
during open attachment.

Comment 2

[Jay Patel [:jay]]

Putting on [nsbeta2-] radar. Not critical to beta2.  Adding "nsbeta3" keyword 
for consideration of a fix for that milestone. 

Comment 3

[Scott MacGregor]

Hmm I promised myself I wouldn't be one of those that clears a beta2- and asks
for reconsideration but I think I'm going to cave in and try.

Because of this bug, it is not possible to open .doc or .xls attachmens on a
message.

I think this problem is made even worse because outgoing attachments aren't
getting the content type set on them correctly by seamonkey (this is another
bug). So trying to open attachments sent by seamonkey in seamonkey really
require the ability to get the extension 'cause the content type isn't set.


I actually fixed this in my tree because I did a bad thing and assumed it might
get a beta2+ before it actually did. My apologies.

Comment 4

[Scott MacGregor]

Posting the fix. 

Comment 5

[Scott MacGregor]

Attachment: proposed fix

Comment 6

[Jay Patel [:jay]]

Putting on [nsbeta2+] radar for beta2 fix. 

Comment 7

[Scott MacGregor]

Fix checked in.

to test, try opening a .doc or a .xls file in messenger. Before, you would have
incorrectly been prompted for a save as dialog. Now you should see your
application get launched by excel or word. 

Comment 8

[pmock]

fyi

Interesting behavior, open attachment works with word 2000 document but not with 
excel 97 documents.  I'll wait to next build.
/Peter

Comment 9

[Scott MacGregor]

Hmmm excel files work for me. Do you have a later version of excel installed on
your machine? Just for kicks, run: regedit.

Then click on HKEY_CLASSES_ROOT so that entry expands. You should see a lot of
file extensions in the list. Is there a .xls extension in that list? 

Comment 10

[pmock]

It's listed.  I should have clarified, I'm still using the 070710-m17 build 
which may not have your fix.  Today build just came available.  I will re-test.
/Pete

Comment 11

[pmock]

Verified on Win32 using the 
 win32 commercial seamonkey build 2000-071009-m17 installed on win98 & winnt

Note: On Macos commercial seamonkey build 2000-071021-m17 does not open the 
attachment b/c the Internet Config bug is still open and the pick application 
button is not implemented yet.

On linux commercial seamonkey build 2000-071009-m17 does not open the 
application either. 
       
Verifying bug as fixed on win32 only.