match up all copies of tinderboxpoller.py

RESOLVED WONTFIX

Status

Release Engineering
General
P3
normal
RESOLVED WONTFIX
10 years ago
5 years ago

People

(Reporter: alice, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
We maintain multiple copies of tinderboxpoller.py (for talos production, talos try, etc).  These versions have drifted and we need to ensure that they are all up to date with the latest patches.
(Reporter)

Comment 1

10 years ago
Also needs to be lined up mozilla/tools/buildbotcustom/changes/tinderboxpoller.py
(Reporter)

Comment 2

10 years ago
Looks like there are changes that are unique to the copy of tinderboxpoller.py in the buildbotcustom directory - do we want these everywhere?  It seems reasonable to me that we should be running the same copy of tinderboxpoller.py everywhere, but there may be some nuance that I'm not seeing.
(Reporter)

Comment 3

10 years ago
Created attachment 323178 [details] [diff] [review]
diff of tinderboxpollery.py for perfmaster and buildbotcustom
(Reporter)

Updated

10 years ago
Attachment #323178 - Attachment is patch: true
Attachment #323178 - Attachment mime type: application/octet-stream → text/plain
We definitely want to be using getPage() instead of urlopen(). The __main__ can stay or go, I'm indifferent there.
Comment on attachment 323178 [details] [diff] [review]
diff of tinderboxpollery.py for perfmaster and buildbotcustom

I'd leave the __main__ if it were up to me. I might even add some more test cases to it.
(Reporter)

Comment 6

10 years ago
So, we want some sort of super tinderboxpoller that is a combination of all the changes made to the perfmaster/tinderboxpoller and the buildbotcustom tinderboxpoller (and anything hanging around in the try talos tinderboxpoller).

Has the buildbotcustom tinderboxpoller been tested?  If I apply those changes to the other tinderboxpollers will things explode?
(In reply to comment #6)
> So, we want some sort of super tinderboxpoller that is a combination of all the
> changes made to the perfmaster/tinderboxpoller and the buildbotcustom
> tinderboxpoller (and anything hanging around in the try talos tinderboxpoller).
> 

Yeah, something like this: http://www.rovang.org/wg/pics/megazord.jpg

> Has the buildbotcustom tinderboxpoller been tested?  If I apply those changes
> to the other tinderboxpollers will things explode?
> 

I personally haven't tested it but as Rob mentioned, the __main__ has a testcase in it.
(Reporter)

Comment 8

10 years ago
Prioritizing as a P3, will require joining all the copies together and then baking on talos stage.
Priority: -- → P3
(Reporter)

Comment 9

10 years ago
Not currently working on this.
Assignee: anodelman → nobody

Updated

10 years ago
Component: Release Engineering: Talos → Release Engineering: Future
(Reporter)

Comment 10

9 years ago
Tinderboxpoller no longer used by Talos.  Bug fixed by default. :)
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → WONTFIX
Moving closed Future bugs into Release Engineering in preparation for removing the Future component.
Component: Release Engineering: Future → Release Engineering
(Assignee)

Updated

5 years ago
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.