436654 - Reset Client Data button deletes passords and form data

Status: RESOLVED INVALID

(Cloud Services :: General, defect)

Description

[Kevin Simmons]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008053004 Minefield/3.0pre
Build Identifier: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9b5) Gecko/2008043010 Fedora/3.0-0.60.beta5.fc9 Firefox/3.0b5

Reset Client Data, as described:
"Delete all locally stored bookmarks and history data"

But it deletes more. All of my stored passwords and form data is deleted as well. Ouch.

On top of that, syncing with weave did not restore the data that was lost. I do have the Saved Passwords, Saved Form Data, and Bookmarks items selected for syncing.

Reproducible: Always

Steps to Reproduce:
1. Select the Reset Client Data button on the Advanced tab
2. Then select OK on the confirmation dialog*
3.
*Dialog box warning: "This will delete all bookmarks and history data.  Are you sure you want to do this?" no mention of any other data.
Actual Results:  
Previously stored passwords are removed fron the user's password database.

Expected Results:  
I expect that only "all bookmarks and history data" to be deleted as per the dialog box and the description on the Advaned tab.

I strongly suggest adding options of what to delete (like the clear private data function in FF
- OR -
labeling the action properly so the user knows what to expect
- OR -
fixing the problem

Comment 1

[Kevin Simmons]

weave v1.30

Comment 2

[Igor Velkov]

When local passwords clears, weave credentials clears too.
Weave should protect own password data when clears passwords.

Comment 3

[Anant Narayanan [:anant]]

The code iterates over all enabled engines, so clicking the button will delete all client data that is currently enabled for sync. I think changing the warning text here would be appropriate.

Comment 4

[Dan Mills [:thunder]]

Perhaps.  Though we should revisit the intent of the method when I wrote it originally:  It was to allow you to restore to a backed-up state by wiping then syncing down the content.

Thus, perhaps a more appropriate way to proceed is to figure out the exact use cases in detail and implement them, then remove the reset local data button altogether.

Comment 5

[Dan Mills [:thunder]]

Pushing to 0.3.

Comment 6

[Dan Mills [:thunder]]

These bugs need to be triaged, removing 0.3 milestone setting.

Comment 7

[Dan Mills [:thunder]]

Reset client data button is no more, so this bug is no longer valid.