436773 - Exclamation points appear in download filenames - seems to cause problems with automatic updates

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P5)

Description

[Andy Mutton]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_2; en-us) AppleWebKit/525.18 (KHTML, like Gecko) Version/3.1.1 Safari/525.18
Build Identifier: 

My extension, Screengrab!, foolishly has an ! in it's name. This propagates through into the filename for the download.

Some of my users have reported problems with the automatic update which have happened only since my latest update, coinciding with the appearance of ! in the url. This seems like a regression, since it didn't used to do it.

I'm told by fligtar that this is not the desired behaviour...
https://bugzilla.mozilla.org/show_bug.cgi?id=431009#c16


Reproducible: Always

Steps to Reproduce:
1. Upload an extension with a ! in it's name.
2. Look at the download URL
Actual Results:  
! in filename

Expected Results:  
no ! in filename

Comment 1

[Wil Clouser [:clouserw]]

I see there is an ! in the name but downloads/updates work for me.  Since fligtar requested the bug I'll assign to him to comment.

Comment 2

[Andy Mutton]

Some of by users are still reporting this as an issue.
I'd almost forgotten about this bug report.
A fix would really be appreciated.

Comment 3

[Justin Scott [:fligtar]]

My only comment would be that we should strip ! from add-on names when creating the file names.

Comment 4

[Michael Kohler [:mkohler]]

This is a mass change. Every comment has "assigned-to-new" in it.

I didn't look through the bugs, so I'm sorry if I change a bug which shouldn't be changed. But I guess these bugs are just bugs that were once assigned and people forgot to change the Status back when unassigning.

Comment 5

[Wil Clouser [:clouserw]]

Should be fixed with Bug 471891.  CCing davedash for confirmation

Comment 6

[Wil Clouser [:clouserw]]

file names are slugified now, so no more exclamation point