config.dtd contains duplicated entities (aboutWarning*.label)

VERIFIED FIXED

Status

Mozilla Localizations
pl / Polish
VERIFIED FIXED
10 years ago
10 years ago

People

(Reporter: Hubert Gajewski, Assigned: marcoos)

Tracking

({verified1.9.0.1})

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
Created attachment 323285 [details] [diff] [review]
Patch

l10n/pl/toolkit/chrome/global/config.dtd contains duplicated entities:

<!ENTITY aboutWarningTitle.label    "Grozi utratą gwarancji!">
<!ENTITY aboutWarningText.label     "Modyfikacja tych ustawień może spowodować problemy, takie jak utrata stabilności i wydajności programu oraz zagrożenia bezpieczeństwa. Należy kontynuować tylko wtedy, gdy ma się pewność tego, co się robi.">
<!ENTITY aboutWarningButton.label   "Zachowam ostrożność, obiecuję!">
<!ENTITY aboutWarningCheckbox.label "Wyświetl to ostrzeżenie następnym razem">

<!ENTITY aboutWarningTitle.label    "Ostrzeżenie przed niebezpieczeństwem">
<!ENTITY aboutWarningText.label     "Ta strona konfiguracyjna pozwala zmodyfikować wszystkie ustawienia programu. Modyfikacja niektórych z nich może spowodować problemy, takie jak: utrata stabilności, uszkodzenie danych, niedziałanie niektórych funkcji programu lub nawet zagrożenia bezpieczeństwa.">
<!ENTITY aboutWarningButton.label   "Rozumiem i chcę kontynuować">
<!ENTITY aboutWarningCheckbox.label "Wyświetl to ostrzeżenie następnym razem">

BTW I have changed contributors' e-mail addresses (there are out-of-date).
Attachment #323285 - Flags: review?(marcoos+bmo)
(Assignee)

Comment 1

10 years ago
Holy crap. 
(Assignee)

Updated

10 years ago
Attachment #323285 - Flags: review?(marcoos+bmo)
Attachment #323285 - Flags: review+
Attachment #323285 - Flags: approval1.9?
(Assignee)

Comment 2

10 years ago
At least this doesn't break anything and Firefox uses the first-defined entities.

It'd be nice to have it in for 3.0.1 or next RC of 3.0, if that happens.

Comment 3

10 years ago
Comment on attachment 323285 [details] [diff] [review]
Patch

a=me, please land this with a check-in comment referencing this bug and my approval.

Please use the fixed1.9.0.1 and verified1.9.0.1 keywords to track landing and testing.

Please cancel the 1.9 flag, too.
Attachment #323285 - Flags: approval1.9.0.1+

Comment 4

10 years ago
Comment on attachment 323285 [details] [diff] [review]
Patch

I can actually cancel myself.
Attachment #323285 - Flags: approval1.9?
(Assignee)

Comment 5

10 years ago
Should I just check this into trunk, or do we have a branch for 3.0.x now?  

Comment 6

10 years ago
cvs trunk is where we're going to work on 3.0.x, we're not going to branch for that at all. So yes, trunk it is.
(Reporter)

Comment 7

10 years ago
Checked in.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: fixed1.9.0.1
Resolution: --- → FIXED
(Reporter)

Comment 8

10 years ago
Verified on Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.9.0.1) Gecko/2008070206 Firefox/3.0.1
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.0.1 → verified1.9.0.1
You need to log in before you can comment on or make changes to this bug.