436810 - Search-results page only shows 1 of 2 reviews

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

There are currently two reviews on https://preview.addons.mozilla.org/en-US/firefox/addon/5428#reviews, yet the search-results page for "QA Companion", https://preview.addons.mozilla.org/en-US/firefox/search?q=qa+companion&cat=all, shows only "1 review"

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Still not showing up, so not a cache bug like I thought -- must've been thinking of something else.  This was as a result of a moderated review, I think.

Comment 2

[Fred Wenzel [:wenzel]]

Attachment: removing "has files" requirement for reviews/ratings count in maintenance script

It seems to me like our reviews and ratings maintenance tasks are not being run on a regular basis anymore?

Either way, I am removing the "has valid files" requirement from the review counts as that will certainly bias the results (hm, I think this is bug 435123 rather than this one here, but it's part of what's needed here too so yeah).

Comment 3

[Fred Wenzel [:wenzel]]

CCing oremj: Jeremy, sorry we are probably bothering you with this for about the 25th time but: The regular maintenance tasks ("php maintenance.php reviews" and "... ratings") are only run in production, not on preview, is that correct? This may well cause the discrepancy we are seeing here.

Comment 4

[Jeremy Orem [:oremj]]

That is correct.

Comment 5

[Fred Wenzel [:wenzel]]

In spite of the maintenance tasks apparently being run now on preview (bug 438832), this is still showing up on preview. However, this works correctly on my dev copy, as well as in production (see the urls in comment 0, without "preview").

I suggest the following (to be done post-AMO-3.4.5): We should add code to incrementally update the review counts as they get written or deleted (we could use this count everywhere then, saving us a bunch of counting queries). Then we should have the maintenance tasks run once on preview to get the counts up to date.

Along with the incremental update, we should fix (and recalculate incrementally) the ratings, in bug 291413.

Not sure if that should be a spinoff bug of this?

Comment 6

[Fred Wenzel [:wenzel]]

(In reply to comment #2)
> Created an attachment (id=324562) [details]
> removing "has files" requirement for reviews/ratings count in maintenance
> script

Thanks for the review, r16792.

Comment 7

[Fred Wenzel [:wenzel]]

This is fixed.

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED