Closed Bug 43687 Opened 20 years ago Closed 18 years ago
Leakage noise fix for class CNewline
Class CNewlineToken allocates an static variable at method GetStringValueXXX() which adds noise to the leak logs. With this patch I move that variable to be a class static, and via a instances count, it is allocated or deleted, as soon as any object is created/all of them are destroyed. I´m considering this would be a good candidate to be #ifdef DEBUG, as I could be hitting performance.
Okay, here is the patch, didn´t have time to post it last Friday. Again, I mention this could be a good candidate to be #ifdef´ed DEBUG, unluess you guys disagree.
Carl has a (I think much better) sollution for this, simply using an static nsString. I can recall you had some arguments against static objects, but I cannot remember if it was limited to nsCOMPtr or what was the point exactly. Could you guys ellaborate on it? Thx,
updated qa contact.
QA Contact: janc → bsharma
email@example.com: Are you still working on this bug ? Can you please add a comment ?
I have not done any work on mozilla for a long time already, so I cannot add any insight.
-> default owner (via mail:Inaky Perez Gonzalez has no time for this)
Assignee: inaky.gonzalez → harishd
The code has changed, a lot, since the bug was filed and I don't think it's an issue anymore. If you disagree please reopen the bug. For now marking INVALID.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.