436936 - Weave UI shows "Offline" in new windows

Status: RESOLVED FIXED

(Cloud Services :: General, defect, P1)

Description

[Daniel Holbert [:dholbert]]

Weave version: 0.1.30
Firefox version: Firefox 3 rc1

Steps to reproduce:
 1. Start firefox
 2. Sign in to Weave. (or, have firefox auto-login)
    --> Weave shows "Idle" in status bar
 3. Ctrl-N for new window.

EXPECTED RESULTS:
  Weave shows "Idle" in new window's status bar

ACTUAL RESULTS:
   Weave shows "Offline" in new window's status bar.  Also, if I click this icon, it gives me the "offline" menu, with the option to sign in. (though choosing 'sign in' here has no effect AFAICT -- it doesn't change the offline status shown.)
   Weave still shows "Idle" in original window, though, and the options shown for that window's weave menu make sense. (sign out, sync now, etc)

I think this may be a regression from bug 435103.

Comment 1

[Atul Varma [:atul]]

Confirmed that this bug exists in the current HG trunk.

Comment 2

[Atul Varma [:atul]]

I've fixed the general case for this, but I'm not a big fan of it.  I think that the cleanest way to do this might be to have Weave.Service's state be completely queryable--its "currentUser" property can be inspected to see whether we're logged in or not, but there doesn't appear to be any way to tell whether the Weave service is currently busy doing something--and then add a single function to the browser window that sets the state of the UI based on the state of the Weave Service.

Another way to do this may be for the Weave service to simply "remember" what the last notification it sent was, and for new browser windows to simply ask for that when they're created and manually call observe() themselves.  But I'm not sure how dependent the methods called by observe() are on the previous state of Weave.

Comment 3

[Dan Mills [:thunder]]

This is working now, marking as fixed.