437018 - xulwindow initialization does not work with GtkMozEmbed

Status: RESOLVED WONTFIX

(Core Graveyard :: Embedding: GTK Widget, defect)

Description

[Oleg Romashin (:romaxa)]

Build xulrunner + TestGtkEmbed from trunk
pref("xpinstall.whitelist.required", false);

./run-mozilla.sh ./TestGtkEmbed https://addons.mozilla.org/en-US/seamonkey/downloads/file/26635/adblock_plus-0.7.5.4-fx+tb+sm.xpi


EXPECTED OUTCOME:
"Software installation" xul window displayed

ACTUAL OUTCOME:
Embed window blocked by not visible modal window
No "Software installation" window

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: Output log

Comment 2

[Oleg Romashin (:romaxa)]

My solution for this bug next:

1) create nsIWindowCreator2 interface
2) create native nsIXULWindow for new windows with 
     nsIWebBrowserChrome::CHROME_OPENAS_CHROME flag
https://bugzilla.mozilla.org/attachment.cgi?id=325081

3) Create embedding window
4) Reparent setup embedding widget as parent of xul window

May be I'm wrong, please correct me...

Comment 3

[Oleg Romashin (:romaxa)]

Attachment: Better fix

Previous proposal was wrong..

GtkMozEmbed EmbedWindow always using nsIDocShellTreeItem::typeContentWrapper, and completely break creation of nsGlobalChromeWindow and related things.


Here is the complete fix for embedding XUL windows in gtkmozembed window

Comment 4

[Oleg Romashin (:romaxa)]

Comment on attachment 325384 [details] [diff] [review]
Better fix

Still some problems there

Comment 5

[Oleg Romashin (:romaxa)]

Attachment: Updated Comment#3 bugfix

Comment 6

[Oleg Romashin (:romaxa)]

Attachment: Remove not related stuff from patch

Bugfix from Bug 408925 was included by mistake..
Also g_main_context_wakeup not reqired.

Sorry for spam

Comment 7

[Oleg Romashin (:romaxa)]

Comment on attachment 325393 [details] [diff] [review]
Remove not related stuff from patch

Any update for review?

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 325393 [details] [diff] [review]
Remove not related stuff from patch

I have no idea about the g_timeout_add and g_source_remove stuff, but the rest looks fine to me.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Embedding: GTK Widget isn't a thing, closing.