xulwindow initialization does not work with GtkMozEmbed

ASSIGNED
Assigned to

Status

ASSIGNED
11 years ago
7 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

Trunk
x86
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

11 years ago
Build xulrunner + TestGtkEmbed from trunk
pref("xpinstall.whitelist.required", false);

./run-mozilla.sh ./TestGtkEmbed https://addons.mozilla.org/en-US/seamonkey/downloads/file/26635/adblock_plus-0.7.5.4-fx+tb+sm.xpi


EXPECTED OUTCOME:
"Software installation" xul window displayed

ACTUAL OUTCOME:
Embed window blocked by not visible modal window
No "Software installation" window
(Assignee)

Comment 1

11 years ago
Created attachment 323532 [details]
Output log
(Assignee)

Comment 2

11 years ago
My solution for this bug next:

1) create nsIWindowCreator2 interface
2) create native nsIXULWindow for new windows with 
     nsIWebBrowserChrome::CHROME_OPENAS_CHROME flag
https://bugzilla.mozilla.org/attachment.cgi?id=325081

3) Create embedding window
4) Reparent setup embedding widget as parent of xul window

May be I'm wrong, please correct me...

Depends on: 408666
(Assignee)

Comment 3

11 years ago
Created attachment 325384 [details] [diff] [review]
Better fix

Previous proposal was wrong..

GtkMozEmbed EmbedWindow always using nsIDocShellTreeItem::typeContentWrapper, and completely break creation of nsGlobalChromeWindow and related things.


Here is the complete fix for embedding XUL windows in gtkmozembed window
Assignee: nobody → romaxa
Status: NEW → ASSIGNED
Attachment #325384 - Flags: review?(mpgritti)
(Assignee)

Comment 4

11 years ago
Comment on attachment 325384 [details] [diff] [review]
Better fix

Still some problems there
Attachment #325384 - Attachment is obsolete: true
Attachment #325384 - Flags: review?(mpgritti)
(Assignee)

Comment 5

11 years ago
Created attachment 325392 [details] [diff] [review]
Updated Comment#3 bugfix
Attachment #325392 - Flags: review?(mpgritti)
(Assignee)

Comment 6

11 years ago
Created attachment 325393 [details] [diff] [review]
Remove not related stuff from patch

Bugfix from Bug 408925 was included by mistake..
Also g_main_context_wakeup not reqired.

Sorry for spam
Attachment #325392 - Attachment is obsolete: true
Attachment #325393 - Flags: review?(mpgritti)
Attachment #325392 - Flags: review?(mpgritti)
(Assignee)

Updated

11 years ago
Attachment #325393 - Flags: review?(mpgritti) → review?(dcamp)
(Assignee)

Comment 7

9 years ago
Comment on attachment 325393 [details] [diff] [review]
Remove not related stuff from patch

Any update for review?
Attachment #325393 - Flags: review?(dcamp) → review?(benjamin)

Updated

9 years ago
Attachment #325393 - Flags: review?(benjamin) → review?(bzbarsky)
Comment on attachment 325393 [details] [diff] [review]
Remove not related stuff from patch

I have no idea about the g_timeout_add and g_source_remove stuff, but the rest looks fine to me.
Attachment #325393 - Flags: review?(bzbarsky) → review+
Component: Embedding: GTK Widget → Embedding: GTK Widget
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.