437168 - Fix Pinstripe smiley CSS

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Phil Ringnalda (:philor)]

Attachment: Fix v.1

Both Qute and Pinstripe have a smileys.css, but while Qute @imports its copy, Pinstripe uses a copy of the same CSS rules inline in messageBody.css instead. That's... suboptimal. The only difference between them is the magic number for font-size, which is 17px for Qute, Classic, and Modern, and 18px in Pinstripe's (in use) messageBody.css but 15px in its smileys.css. I was strongly tempted to switch it to the same 17px everything else uses, but in the end chickened out, since nobody seems to be clamoring for 1 less pixel of font-size for smiley images on OS X.  

Also? Yet another blame-screwing conversion from DOS newlines.

Comment 1

[Phil Ringnalda (:philor)]

Attachment: -w

Marginally more pleasant to read as a -w diff.

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 323651 [details] [diff] [review]
Fix v.1

Tiny nit - there's a stray space after:

+.moz-vcard-title-property {
+} 

and 
+.moz-vcard-badge:hover {
+  -moz-image-region: rect(32px 32px 64px 0px);
+} 

r=mkmelin with that

Comment 3

[Phil Ringnalda (:philor)]

mail/themes/pinstripe/mail/smileys.css 1.4
mail/themes/pinstripe/mail/messageBody.css 1.11